Revert back AsyncHttpClient#844 and detach channel in finishUpdate, close AsyncHttpClient#844

Author: slandelle

providers/netty3/src/main/java/org/asynchttpclient/providers/netty3/future/NettyResponseFuture.java

@@ -388,6 +388,11 @@ public void attachChannel(Channel channel, boolean reuseChannel) {
         this.reuseChannel = reuseChannel;
     }
 
+    public void detachChannel() {
+        this.channel = null;
+        this.reuseChannel = false;
+    }
+
     public Channel channel() {
         return channel;
     }

providers/netty3/src/main/java/org/asynchttpclient/providers/netty3/handler/HttpProtocol.java

@@ -189,13 +189,15 @@ private void addType3NTLMAuthorizationHeader(String auth, FluentCaseInsensitiveS
 
     private void finishUpdate(final NettyResponseFuture<?> future, Channel channel, boolean expectOtherChunks) throws IOException {
 
-        markAsDone(future, channel);
+        future.detachChannel();
 
         boolean keepAlive = future.isKeepAlive();
         if (expectOtherChunks && keepAlive)
             channelManager.drainChannelAndOffer(channel, future);
         else
             channelManager.tryToOfferChannelToPool(channel, keepAlive, future.getPartitionId());
+
+        markAsDone(future, channel);
     }
 
     private boolean updateBodyAndInterrupt(NettyResponseFuture<?> future, AsyncHandler<?> handler, NettyResponseBodyPart bodyPart)

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/future/NettyResponseFuture.java

@@ -388,6 +388,11 @@ public void attachChannel(Channel channel, boolean reuseChannel) {
         this.reuseChannel = reuseChannel;
     }
 
+    public void detachChannel() {
+        this.channel = null;
+        this.reuseChannel = false;
+    }
+
     public Channel channel() {
         return channel;
     }

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/handler/HttpProtocol.java

@@ -190,13 +190,15 @@ private void addType3NTLMAuthorizationHeader(String authenticateHeader, FluentCa
 
     private void finishUpdate(final NettyResponseFuture<?> future, Channel channel, boolean expectOtherChunks) throws IOException {
 
-        markAsDone(future, channel);
+        future.detachChannel();
 
         boolean keepAlive = future.isKeepAlive();
         if (expectOtherChunks && keepAlive)
             channelManager.drainChannelAndOffer(channel, future);
         else
             channelManager.tryToOfferChannelToPool(channel, keepAlive, future.getPartitionId());
+
+        markAsDone(future, channel);
     }
 
     private boolean updateBodyAndInterrupt(NettyResponseFuture<?> future, AsyncHandler<?> handler, NettyResponseBodyPart bodyPart) throws Exception {