Fix send NEC 16 bit address bug. Improved SendDemo example for #760

Author: ArminJo

README.md

@@ -36,8 +36,7 @@ This is a quite old but maybe useful wiki for this library.
 - The decoded result is now in in `IrReceiver.decodedIRData` and not in `results` any more, therefore replace any occurrences of `results.value`  and / or `results.decode_type` (and similar) to `IrReceiver.decodedIRData.decodedRawData` and / or `IrReceiver.decodedIRData.decodedRawData`.
 - Overflow, Repeat and other flags are now in [`IrReceiver.receivedIRData.flags`](https://github.com/Arduino-IRremote/Arduino-IRremote/blob/master/src/IRremote.h#L126).
 - Seldom used: `results.rawbuf` and `results.rawlen` must be replaced by `IrReceiver.decodedIRData.rawDataPtr->rawbuf` and `IrReceiver.decodedIRData.rawDataPtr->rawlen`.
-- The old functions `sendNEC()` and `sendJVC()` are deprecated and renamed to `sendNECMSB()` and `sendJVCMSB()` to make it clearer that they send data with MSB first, which is not the standard for NEC and JVC.
-They are kept as well as other old send functions to enable usage of **old** 32 bit IR data codes.
+- The old functions `sendNEC()` and `sendJVC()` are deprecated and renamed to `sendNECMSB()` and `sendJVCMSB()` to make it clearer that they send data with MSB first, which is not the standard for NEC and JVC. Use them to send your **old 32 bit IR data codes**.
 In the new version you will send NEC commands not by 32 bit codes but by a (constant) 8 bit address and an 8 bit command.
 
 # FAQ

examples/IRsendDemo/IRsendDemo.ino

@@ -13,7 +13,6 @@
  */
 
 //#define EXCLUDE_EXOTIC_PROTOCOLS // saves around 240 bytes program space if IrSender.write is used
-
 #include <IRremote.h>
 #if defined(__AVR_ATtiny25__) || defined(__AVR_ATtiny45__) || defined(__AVR_ATtiny85__) || defined(__AVR_ATtiny87__) || defined(__AVR_ATtiny167__)
 #include "ATtinySerialOut.h"
@@ -83,10 +82,24 @@ void loop() {
                 "0017 0806"), 0); //stop bit, no repeat possible, because of missing repeat pattern
         delay(2000);
 
+        /*
+         * With sendNECRaw() you can send even "forbidden" codes with parity errors
+         */
         Serial.println(
                 F(
-                        "Send NECRaw 0xCC340102 with 16 bit address 0x102 and command 0x34 which results in a parity error, since CC != ~34"));
-        IrSender.sendNECRaw(0xCC340102, sRepeats);
+                        "Send NEC with 16 bit address 0x0102 and command 0x34 with NECRaw(0xCC340102) which results in a parity error, since 34 == ~CB and not C0"));
+        IrSender.sendNECRaw(0xC0340102, sRepeats);
+        delay(2000);
+
+        /*
+         * With Send sendNECMSB() you can send your old 32 bit codes.
+         * To convert one into the other, you must reverse the byte positions and then reverse all positions of each byte.
+         * Example:
+         * 0xCB340102 byte reverse -> 0x020134CB bit reverse-> 40802CD3
+         *
+         */
+        Serial.println(F("NEC with 16 bit address 0x0102 and command 0x34 with old 32 bit format MSB first"));
+        IrSender.sendNECMSB(0x40802CD3, 32, false);
         delay(2000);
     }
 

src/IRremote.h

@@ -87,7 +87,7 @@
  */
 #if !defined(MARK_EXCESS_MICROS)
 //#define MARK_EXCESS_MICROS    50
-#define MARK_EXCESS_MICROS    20 // recommended for the cheap VS1838 modules
+#define MARK_EXCESS_MICROS    20 // 20 is recommended for the cheap VS1838 modules
 #endif
 
 //------------------------------------------------------------------------------

src/ir_NEC.cpp

@@ -92,6 +92,8 @@ void IRsend::sendNEC(uint16_t aAddress, uint8_t aCommand, uint8_t aNumberOfRepea
         // assume 8 bit address -> send 8 address bits and then 8 inverted address bits LSB first
         tRawData.UByte.LowByte = aAddress;
         tRawData.UByte.MidLowByte = ~tRawData.UByte.LowByte;
+    } else {
+        tRawData.UWord.LowWord = aAddress;
     }
 
     // send 8 command bits and then 8 inverted command bits LSB first