Printout of LSB or MSB first

Author: ArminJo

.github/workflows/LibraryBuild.yml

@@ -53,6 +53,7 @@ jobs:
           - arduino:megaavr:nona4809:mode=off
           - digistump:avr:digispark-tiny:clock=clock1
           - ATTinyCore:avr:attinyx5:chip=85,clock=1internal
+          - TinyCore:avr:tiny32
           - arduino:samd:arduino_zero_native
           - MegaCore:avr:128:bootloader=no_bootloader,eeprom=keep,BOD=2v7,LTO=Os,clock=8MHz_internal # ATmega128
           - esp32:esp32:featheresp32:FlashFreq=80
@@ -91,6 +92,10 @@ jobs:
             platform-url: http://drazzy.com/package_drazzy.com_index.json
             sketches-exclude: IR2Keyboard,IRUnitTest,IRrelay,IRrecord,IRreceiveDumpV2,IRsendProntoDemo,MicroGirs,IRreceiveDemo,BoseWaveSendDemo,IRDispatcherDemo # Does not fit in FLASH or RAM
 
+          - arduino-boards-fqbn: TinyCore:avr:tiny32
+            platform-url: https://raw.githubusercontent.com/xukangmin/TinyCore/master/avr/package/package_tinycore_index.json
+            sketches-exclude: IR2Keyboard
+
           - arduino-boards-fqbn: MegaCore:avr:128:bootloader=no_bootloader,eeprom=keep,BOD=2v7,LTO=Os,clock=8MHz_internal
             platform-url: https://mcudude.github.io/MegaCore/package_MCUdude_MegaCore_index.json
             arduino-platform: arduino:avr,MegaCore:avr # gcc is taken from arduino:avr

src/IRremote.h

@@ -130,6 +130,8 @@ typedef enum {
 #define IRDATA_TOGGLE_BIT_MASK          0x08
 #define IRDATA_FLAGS_EXTRA_INFO         0x10 // there is unexpected extra info not contained in address and data (e.g. Kaseikyo unknown vendor ID)
 #define IRDATA_FLAGS_WAS_OVERFLOW       0x40 // irparams.rawlen is 0 in this case to avoid endless overflow
+#define IRDATA_FLAGS_IS_LSB_FIRST       0x00
+#define IRDATA_FLAGS_IS_MSB_FIRST       0x80 // Just for info. Value is simply determined by the protocol
 
 struct IRData {
     decode_type_t protocol;     ///< UNKNOWN, NEC, SONY, RC5, ...
@@ -283,10 +285,10 @@ class IRrecv {
      * The main decoding functions used by the individual decoders
      */
     bool decodePulseDistanceData(uint8_t aNumberOfBits, uint8_t aStartOffset, unsigned int aBitMarkMicros,
-            unsigned int aOneSpaceMicros, unsigned int aZeroSpaceMicros, bool aMSBfirst = true);
+            unsigned int aOneSpaceMicros, unsigned int aZeroSpaceMicros, bool aMSBfirst);
 
     bool decodePulseWidthData(uint8_t aNumberOfBits, uint8_t aStartOffset, unsigned int aOneMarkMicros,
-            unsigned int aZeroMarkMicros, unsigned int aBitSpaceMicros, bool aMSBfirst = true);
+            unsigned int aZeroMarkMicros, unsigned int aBitSpaceMicros, bool aMSBfirst);
 
     bool decodeBiPhaseData(uint8_t aNumberOfBits, uint8_t aStartOffset, uint8_t aValueOfSpaceToMarkTransition,
             unsigned int aBiphaseTimeUnit);
@@ -317,7 +319,7 @@ class IRrecv {
     /*
      * Old functions
      */
-    bool decode(decode_results *aResults) __attribute__ ((deprecated ("You should use decode() without a parameter."))); // deprecated
+    bool decode(decode_results *aResults) __attribute__ ((deprecated ("Please use decode() without a parameter."))); // deprecated
     bool decodeWhynter();
 
     bool decodeSAMSUNG() __attribute__ ((deprecated ("Renamed to decodeSamsung()"))); // deprecated
@@ -395,7 +397,7 @@ class IRsend {
     void enableIROut(int khz);
 
     void sendPulseDistanceWidthData(unsigned int aOneMarkMicros, unsigned int aOneSpaceMicros, unsigned int aZeroMarkMicros,
-            unsigned int aZeroSpaceMicros, uint32_t aData, uint8_t aNumberOfBits, bool aMSBfirst = true, bool aSendStopBit = false);
+            unsigned int aZeroSpaceMicros, uint32_t aData, uint8_t aNumberOfBits, bool aMSBfirst, bool aSendStopBit = false);
     void sendBiphaseData(unsigned int aBiphaseTimeUnit, uint32_t aData, uint8_t aNumberOfBits);
 
     void mark(uint16_t timeMicros);
@@ -472,18 +474,18 @@ class IRsend {
      */
     void sendDenon(unsigned long data, int nbits);
     void sendDISH(unsigned long data, int nbits);
-    void sendJVC(unsigned long data, int nbits, bool repeat = false);
+    void sendJVC(unsigned long data, int nbits, bool repeat = false) __attribute__ ((deprecated ("This old function sends MSB first! Please use sendJVC((uint8_t) aAddress, aCommand, aNumberOfRepeats).")));
     void sendLG(unsigned long data, int nbits);
-    void sendNEC(uint32_t data, uint8_t nbits, bool repeat = false);
-    void sendPanasonic(uint16_t aAddress, uint32_t aData);
+    void sendNEC(uint32_t data, uint8_t nbits, bool repeat = false) __attribute__ ((deprecated ("This old function sends MSB first! Please use sendNECRaw().")));
+    void sendPanasonic(uint16_t aAddress, uint32_t aData) __attribute__ ((deprecated ("This old function sends MSB first! Please use sendPanasonic(aAddress, aCommand, aNumberOfRepeats).")));
     void sendRC5(uint32_t data, uint8_t nbits);
     void sendRC5ext(uint8_t addr, uint8_t cmd, boolean toggle);
     void sendRC6(uint32_t data, uint8_t nbits);
     void sendRC6(uint64_t data, uint8_t nbits);
     void sendSharpRaw(unsigned long data, int nbits);
     void sendSharp(unsigned int address, unsigned int command);
-    void sendSAMSUNG(unsigned long data, int nbits);
-    void sendSony(unsigned long data, int nbits);
+    void sendSAMSUNG(unsigned long data, int nbits); __attribute__ ((deprecated ("This old function sends MSB first! Please use sendSamsung().")));
+    void sendSony(unsigned long data, int nbits) __attribute__ ((deprecated ("This old function sends MSB first! Please use sendSony(aAddress, aCommand, aNumberOfRepeats).")));;
     void sendWhynter(unsigned long data, int nbits);
 
 #if defined(USE_SOFT_SEND_PWM) || defined(USE_NO_SEND_PWM)

src/irReceive.cpp

@@ -910,15 +910,26 @@ void IRrecv::printIRResultShort(Print *aSerial, IRData *aIRDataPtr, uint16_t aLe
         /*
          * Print raw data
          */
-        aSerial->print(F(" Raw-Data=0x"));
-        aSerial->print(aIRDataPtr->decodedRawData, HEX);
+        if (!(aIRDataPtr->flags & IRDATA_FLAGS_IS_REPEAT) || aIRDataPtr->decodedRawData != 0) {
+            aSerial->print(F(" Raw-Data=0x"));
+            aSerial->print(aIRDataPtr->decodedRawData, HEX);
 
-        /*
-         * Print number of bits processed
-         */
-        aSerial->print(F(" ("));
-        aSerial->print(aIRDataPtr->numberOfBits, DEC);
-        aSerial->println(F(" bits)"));
+            /*
+             * Print number of bits processed
+             */
+            aSerial->print(F(" ("));
+            aSerial->print(aIRDataPtr->numberOfBits, DEC);
+            aSerial->print(F(" bits)"));
+
+            if (aIRDataPtr->flags & IRDATA_FLAGS_IS_MSB_FIRST) {
+                aSerial->println(F(" MSB first"));
+            } else {
+                aSerial->println(F(" LSB first"));
+
+            }
+        } else {
+            aSerial->println();
+        }
     }
 
 }

src/ir_BoseWave.cpp

@@ -104,6 +104,7 @@ bool IRrecv::decodeBoseWave() {
     }
 
     // Success
+//    decodedIRData.flags = IRDATA_FLAGS_IS_LSB_FIRST; // Not required, since this is the start value
     uint16_t tDecodedValue = decodedIRData.decodedRawData;
     uint8_t tCommandNotInverted = tDecodedValue & 0xFF;
     uint8_t tCommandInverted = tDecodedValue >> 8;
@@ -116,7 +117,7 @@ bool IRrecv::decodeBoseWave() {
 
     // check for repeat
     if (decodedIRData.rawDataPtr->rawbuf[0] < ((BOSEWAVE_REPEAT_SPACE + (BOSEWAVE_REPEAT_SPACE / 4)) / MICROS_PER_TICK)) {
-        decodedIRData.flags = IRDATA_FLAGS_IS_REPEAT;
+        decodedIRData.flags = IRDATA_FLAGS_IS_REPEAT | IRDATA_FLAGS_IS_LSB_FIRST;
     }
 
     decodedIRData.command = tCommandNotInverted;

src/ir_Denon.cpp

@@ -136,7 +136,7 @@ bool IRrecv::decodeDenon() {
     }
 
     // Read the bits in
-    if (!decodePulseDistanceData(DENON_BITS, 1, DENON_BIT_MARK, DENON_ONE_SPACE, DENON_ZERO_SPACE)) {
+    if (!decodePulseDistanceData(DENON_BITS, 1, DENON_BIT_MARK, DENON_ONE_SPACE, DENON_ZERO_SPACE, MSB_FIRST)) {
         DBG_PRINT("Denon: ");
         DBG_PRINTLN("Decode failed");
         return false;
@@ -150,6 +150,7 @@ bool IRrecv::decodeDenon() {
     }
 
     // Success
+    decodedIRData.flags = IRDATA_FLAGS_IS_MSB_FIRST;
     uint8_t tFrameBits = decodedIRData.decodedRawData & 0x03;
     decodedIRData.command = decodedIRData.decodedRawData >> DENON_FRAME_BITS;
     decodedIRData.address = decodedIRData.command >> DENON_COMMAND_BITS;
@@ -161,7 +162,7 @@ bool IRrecv::decodeDenon() {
         repeatCount++;
         if (tFrameBits == 0x3 || tFrameBits == 0x1) {
             // We are in the auto repeated frame with the inverted command
-            decodedIRData.flags = IRDATA_FLAGS_IS_AUTO_REPEAT;
+            decodedIRData.flags = IRDATA_FLAGS_IS_AUTO_REPEAT | IRDATA_FLAGS_IS_MSB_FIRST;
             // Check parity of consecutive received commands. There is no parity in one data set.
             uint8_t tLastCommand = lastDecodedCommand;
             if (tLastCommand != (uint8_t) (~tCommand)) {

src/ir_Dish.cpp

@@ -38,7 +38,7 @@ void IRsend::sendDISH(unsigned long data, int nbits) {
     mark(DISH_HEADER_MARK);
     space(DISH_HEADER_SPACE);
 
-    sendPulseDistanceWidthData(DISH_BIT_MARK, DISH_ONE_SPACE, DISH_BIT_MARK, DISH_ZERO_SPACE, data, nbits);
+    sendPulseDistanceWidthData(DISH_BIT_MARK, DISH_ONE_SPACE, DISH_BIT_MARK, DISH_ZERO_SPACE, data, nbits, MSB_FIRST);
     mark(DISH_HEADER_MARK); //added 26th March 2016, by AnalysIR ( https://www.AnalysIR.com )
     space(0);  // Always end with the LED off
     interrupts();

src/ir_JVC.cpp

@@ -79,7 +79,7 @@ void IRsend::sendJVC(uint8_t aAddress, uint8_t aCommand, uint8_t aNumberOfRepeat
 
         // Address + command
         sendPulseDistanceWidthData(JVC_BIT_MARK, JVC_ONE_SPACE, JVC_BIT_MARK, JVC_ZERO_SPACE,
-                aAddress | aCommand << JVC_ADDRESS_BITS, JVC_BITS, LSB_FIRST, SEND_STOP_BIT);
+                aAddress | (aCommand << JVC_ADDRESS_BITS), JVC_BITS, LSB_FIRST, SEND_STOP_BIT);
 
         interrupts();
 
@@ -116,7 +116,7 @@ bool IRrecv::decodeJVC() {
             /*
              * We have a repeat here, so do not check for start bit
              */
-            decodedIRData.flags = IRDATA_FLAGS_IS_REPEAT;
+            decodedIRData.flags = IRDATA_FLAGS_IS_REPEAT | IRDATA_FLAGS_IS_LSB_FIRST;
         }
     } else {
 
@@ -137,6 +137,7 @@ bool IRrecv::decodeJVC() {
     }
 
     // Success
+//    decodedIRData.flags = IRDATA_FLAGS_IS_LSB_FIRST; // Not required, since this is the start value
     uint8_t tCommand = decodedIRData.decodedRawData >> JVC_ADDRESS_BITS;  // upper 8 bits of LSB first value
     uint8_t tAddress = decodedIRData.decodedRawData & 0xFF;    // lowest 8 bit of LSB first value
 
@@ -209,7 +210,7 @@ bool IRrecv::decodeJVC() {
 //+=============================================================================
 // JVC does NOT repeat by sending a separate code (like NEC does).
 // The JVC protocol repeats by skipping the header.
-//
+// Old version with MSB first Data
 void IRsend::sendJVC(unsigned long data, int nbits, bool repeat) {
     // Set IR carrier frequency
     enableIROut(38);
@@ -220,7 +221,7 @@ void IRsend::sendJVC(unsigned long data, int nbits, bool repeat) {
         space(JVC_HEADER_SPACE);
     }
 
-    // Data + stop bit
+    // Old version with MSB first Data
     sendPulseDistanceWidthData(JVC_BIT_MARK, JVC_ONE_SPACE, JVC_BIT_MARK, JVC_ZERO_SPACE, data, nbits, MSB_FIRST, SEND_STOP_BIT);
 
 }

src/ir_Kaseikyo.cpp

@@ -184,6 +184,9 @@ bool IRrecv::decodeKaseikyo() {
         DBG_PRINTLN("Address, command + parity decode failed");
         return false;
     }
+
+    // Success
+//    decodedIRData.flags = IRDATA_FLAGS_IS_LSB_FIRST; // Not required, since this is the start value
     LongUnion tValue;
     tValue.ULong = decodedIRData.decodedRawData;
     decodedIRData.address = (tValue.UWord.LowWord >> KASEIKYO_VENDOR_ID_PARITY_BITS); // remove vendor parity
@@ -198,7 +201,7 @@ bool IRrecv::decodeKaseikyo() {
         DBG_PRINT(decodedIRData.decodedRawData, HEX);
         DBG_PRINT(" VendorID=0x");
         DBG_PRINTLN(tVendorId, HEX);
-        decodedIRData.flags = IRDATA_FLAGS_PARITY_FAILED;
+        decodedIRData.flags = IRDATA_FLAGS_PARITY_FAILED | IRDATA_FLAGS_IS_LSB_FIRST;
     }
 
     if (tProtocol == KASEIKYO) {
@@ -219,7 +222,7 @@ bool IRrecv::decodeKaseikyo() {
         DBG_PRINT(decodedIRData.address, HEX);
         DBG_PRINT(" command=0x");
         DBG_PRINTLN(decodedIRData.command, HEX);
-        decodedIRData.flags = IRDATA_FLAGS_PARITY_FAILED;
+        decodedIRData.flags |= IRDATA_FLAGS_PARITY_FAILED;
     }
 
     // check for repeat
@@ -267,6 +270,7 @@ bool IRrecv::decodePanasonic() {
 
 #endif
 
+// Old version with MSB first Data
 void IRsend::sendPanasonic(uint16_t aAddress, uint32_t aData) {
     // Set IR carrier frequency
     enableIROut(37); // 36.7kHz is the correct frequency
@@ -275,13 +279,13 @@ void IRsend::sendPanasonic(uint16_t aAddress, uint32_t aData) {
     mark(KASEIKYO_HEADER_MARK);
     space(KASEIKYO_HEADER_SPACE);
 
-    // Address
+    // Old version with MSB first Data Address
     sendPulseDistanceWidthData(KASEIKYO_BIT_MARK, KASEIKYO_ONE_SPACE, KASEIKYO_BIT_MARK, KASEIKYO_ZERO_SPACE, aAddress,
-    KASEIKYO_ADDRESS_BITS);
+    KASEIKYO_ADDRESS_BITS, MSB_FIRST);
 
-    // Data + stop bit
+    // Old version with MSB first Data Data + stop bit
     sendPulseDistanceWidthData(KASEIKYO_BIT_MARK, KASEIKYO_ONE_SPACE, KASEIKYO_BIT_MARK, KASEIKYO_ZERO_SPACE, aData,
-    KASEIKYO_DATA_BITS);
+    KASEIKYO_DATA_BITS, MSB_FIRST);
 
 }
 

src/ir_LG.cpp

@@ -92,7 +92,7 @@ void IRsend::sendLG(uint8_t aAddress, uint16_t aCommand, uint8_t aNumberOfRepeat
         tTempForChecksum >>= 4; // shift by a nibble
     }
     tRawData |= tChecksum;
-    sendLG(tRawData, aNumberOfRepeats, aIsRepeat);
+    sendLGRaw(tRawData, aNumberOfRepeats, aIsRepeat);
 }
 
 /*
@@ -155,7 +155,7 @@ bool IRrecv::decodeLG() {
     if (decodedIRData.rawDataPtr->rawlen == 4) {
         if (MATCH_SPACE(decodedIRData.rawDataPtr->rawbuf[2], LG_REPEAT_HEADER_SPACE)
                 && MATCH_MARK(decodedIRData.rawDataPtr->rawbuf[3], LG_BIT_MARK)) {
-            decodedIRData.flags = IRDATA_FLAGS_IS_REPEAT;
+            decodedIRData.flags = IRDATA_FLAGS_IS_REPEAT | IRDATA_FLAGS_IS_MSB_FIRST;
             decodedIRData.address = lastDecodedAddress;
             decodedIRData.command = lastDecodedCommand;
             return true;
@@ -184,6 +184,7 @@ bool IRrecv::decodeLG() {
     }
 
     // Success
+    decodedIRData.flags = IRDATA_FLAGS_IS_MSB_FIRST;
     decodedIRData.command = (decodedIRData.decodedRawData >> LG_CHECKSUM_BITS) & 0xFFFF;
     decodedIRData.address = decodedIRData.decodedRawData >> (LG_COMMAND_BITS + LG_CHECKSUM_BITS); // first 8 bit
 

src/ir_Lego.cpp

@@ -184,6 +184,7 @@ bool IRrecv::decodeLegoPowerFunctions() {
     }
 
     // Success
+    decodedIRData.flags = IRDATA_FLAGS_IS_MSB_FIRST;
     uint16_t tDecodedValue = decodedIRData.decodedRawData;
     uint8_t tToggleEscapeChannel = tDecodedValue >> (LEGO_MODE_BITS + LEGO_COMMAND_BITS + LEGO_PARITY_BITS);
     uint8_t tMode = (tDecodedValue >> (LEGO_COMMAND_BITS + LEGO_PARITY_BITS)) & 0xF;
@@ -210,7 +211,7 @@ bool IRrecv::decodeLegoPowerFunctions() {
         DBG_PRINT(", 0x");
         DBG_PRINTLN(tData, HEX);
         // might not be an error, so just continue
-        decodedIRData.flags = IRDATA_FLAGS_PARITY_FAILED;
+        decodedIRData.flags = IRDATA_FLAGS_PARITY_FAILED | IRDATA_FLAGS_IS_MSB_FIRST;
     }
 
     /*