Simply fail if assertion is not thrown

f2prateek · f2prateek · commit 4af667fcba89 · 2014-09-25T16:24:08.000-06:00
diff --git a/picasso/src/test/java/com/squareup/picasso/PicassoTest.java b/picasso/src/test/java/com/squareup/picasso/PicassoTest.java
@@ -187,11 +187,8 @@ public class PicassoTest {
     boolean caught = false;
     try {
       picasso.complete(hunter);
-    } catch (AssertionError error) {
-      caught = true;
-    }
-    if (!caught) {
       fail("Calling complete() with null LoadedFrom should throw");
+    } catch (AssertionError expected) {
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -187,11 +187,8 @@ public class PicassoTest {`
`187`	`187`	`boolean caught = false;`
`188`	`188`	`try {`
`189`	`189`	`picasso.complete(hunter);`
`190`		`- } catch (AssertionError error) {`
`191`		`- caught = true;`
`192`		`- }`
`193`		`- if (!caught) {`
`194`	`190`	`fail("Calling complete() with null LoadedFrom should throw");`
	`191`	`+ } catch (AssertionError expected) {`
`195`	`192`	`}`
`196`	`193`	`}`
`197`	`194`