Skip to content

Commit 621b940

Browse files
committed
Merge pull request square#378 from square/dimitris/tiny
No iterator on joined requests, minor javadoc fix.
2 parents 404a423 + d166c9f commit 621b940

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

picasso/src/main/java/com/squareup/picasso/Picasso.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,9 @@ void complete(BitmapHunter hunter) {
300300
Bitmap result = hunter.getResult();
301301
LoadedFrom from = hunter.getLoadedFrom();
302302

303-
for (Action join : joined) {
303+
//noinspection ForLoopReplaceableByForEach
304+
for (int i = 0, n = joined.size(); i < n; i++) {
305+
Action join = joined.get(i);
304306
if (join.isCancelled()) {
305307
continue;
306308
}

picasso/src/main/java/com/squareup/picasso/RequestCreator.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ public class RequestCreator {
3939
private boolean noFade;
4040
private boolean deferred;
4141
private int placeholderResId;
42-
private Drawable placeholderDrawable;
4342
private int errorResId;
43+
private Drawable placeholderDrawable;
4444
private Drawable errorDrawable;
4545

4646
RequestCreator(Picasso picasso, Uri uri, int resourceId) {
@@ -258,6 +258,10 @@ public void fetch() {
258258
* {@literal @}Override public void onBitmapFailed() {
259259
* setBackgroundResource(R.drawable.profile_error);
260260
* }
261+
*
262+
* {@literal @}Override public void onPrepareLoad(Drawable placeHolderDrawable) {
263+
* frame.setBackgroundDrawable(placeHolderDrawable);
264+
* }
261265
* }
262266
* </pre></blockquote>
263267
* Implementing on a view holder object for use inside of an adapter:
@@ -273,6 +277,10 @@ public void fetch() {
273277
* {@literal @}Override public void onBitmapFailed() {
274278
* frame.setBackgroundResource(R.drawable.profile_error);
275279
* }
280+
*
281+
* {@literal @}Override public void onPrepareLoad(Drawable placeHolderDrawable) {
282+
* frame.setBackgroundDrawable(placeHolderDrawable);
283+
* }
276284
* }
277285
* </pre></blockquote>
278286
* <p>

0 commit comments

Comments
 (0)