Make MSVC use release builds and enable warnings as errors

Author: timfel

graalpython/com.oracle.graal.python.cext/CMakeLists.txt

@@ -54,7 +54,40 @@ set(TARGET_LIBPYTHON "python-native")
 ######################################################################
 
 if (MSVC)
-  # set(CFLAGS_WARNINGS /Wall /WX)
+  SET(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "" FORCE)
+  SET(CFLAGS_WARNINGS /Wall /WX
+    # Many warnings that are just MSVC being a bit pedantic
+    /wd4255 # no function prototype given: converting '()' to '(void)'
+    /wd4820 # padding added after data member
+    /wd4100 # unreferenced formal parameter
+    /wd4200 # nonstandard extension used: zero-sized array in struct/union
+    /wd4996 # This function or variable may be unsafe ... see _CRT_SECURE_NO_WARNINGS
+    /wd4668 # ... is not defined as a preprocessor macro, replacing with '0' for '#if/#elif'
+    /wd4115 # named type definition in parentheses
+    /wd4152 # nonstandard extension, function/data pointer conversion in expression
+    /wd5045 # Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
+    /wd4047 # 'int64_t' differs in levels of indirection from 'char []' / 'void *'
+    /wd4242 # conversion from 'int' to 'char', possible loss of data
+    /wd4244 # conversion from 'long' to 'char', possible loss of data
+    /wd4267 # conversion from 'size_t' to 'int', possible loss of data
+    /wd4127 # conditional expression is constant
+    /wd4702 # unreachable code
+    /wd4101 # unreferenced local variable
+    /wd4456 # declaration hides previous local declaration
+    /wd4459 # declaration hides global declaration
+    /wd4061 # enumerator X in switch of enum Y is not explicitly handled by a case label
+    /wd4464 # relative include path contains '..'
+    /wd4710 # 'fprintf': function not inlined
+    /wd4706 # assignment within conditional expression
+
+    # Some that I'm not so happy about
+    /wd4232 # sre: nonstandard extension used: 'ml_meth': address of dllimport 'Py_GenericAlias' is not static, identity not guaranteed
+    /wd4191 # sre and sqlite: 'type cast': like unsafe conversion from 'PyObject *(__cdecl *)(MatchObject *,PyObject *const *,Py_ssize_t)' to 'void (__cdecl *)(void)'
+    /wd4918 # sre: invalid character in pragma optimization list
+    /wd4701 # cpython_unicodedata: potentially uninitialized local variable 'rc' used
+    /wd4574 # sqlite: 'SQLITE_ATOMIC_INTRINSICS' is defined to be '0': did you mean to use '#if SQLITE_ATOMIC_INTRINSICS'?
+    /wd4310 # xmlparse: cast truncates constant value
+  )
 else()
   set(CFLAGS_WARNINGS -Wall -Werror -Wno-unused-function -Wno-unused-variable -Wno-unused-const-variable
                     -Wno-unknown-warning-option

graalpython/com.oracle.graal.python.cext/src/abstract.c

@@ -952,7 +952,7 @@ binary_op(PyObject *v, PyObject *w, const int op_slot, const char *op_name)
     if (result == Py_NotImplemented) {
         Py_DECREF(result);
 
-        if (op_slot == NB_SLOT(nb_rshift) &&
+        if (op_slot == (int)NB_SLOT(nb_rshift) &&
             PyCFunction_CheckExact(v) &&
             strcmp(((PyCFunctionObject *)v)->m_ml->ml_name, "print") == 0)
         {

graalpython/com.oracle.graal.python.cext/src/bytesobject.c

@@ -166,7 +166,7 @@ PyBytes_FromFormatV(const char *format, va_list vargs)
                                              (__buffer)[(__pos)++] = (__spec);\
                                          } while(0)
 
-    for(int i=0; i < sizeof(buffer); i++) {
+    for(int i=0; i < (int)sizeof(buffer); i++) {
     	buffer[i] = '\0';
     }
 

graalpython/com.oracle.graal.python.cext/src/capi.c

@@ -262,7 +262,7 @@ static int cdata_getbuffer(PyObject* type, Py_buffer* view, int flags) {
 }
 
 static void cdata_releasebuffer(PyObject* obj, Py_buffer* view) {
-    return GraalPyTruffleCData_ReleaseBuffer(obj, view);
+    GraalPyTruffleCData_ReleaseBuffer(obj, view);
 }
 
 PyAPI_FUNC(void) PyTruffleCData_InitBufferProtocol(PyObject* type) {
@@ -801,7 +801,7 @@ PyAPI_FUNC(int) tuffle_check_basesize_for_getstate(PyTypeObject* type, int slot_
     if (type->tp_weaklistoffset)
         basicsize += sizeof(PyObject *);
     if (slot_num)
-        basicsize += sizeof(PyObject *) * PyList_GET_SIZE(slot_num);
+        basicsize += sizeof(PyObject *) * slot_num;
     return type->tp_basicsize > basicsize;
 }
 

graalpython/com.oracle.graal.python.cext/src/gcmodule.c

@@ -1593,7 +1593,8 @@ gc_collect_main(PyThreadState *tstate, int generation,
     PyGC_Head unreachable; /* non-problematic unreachable trash */
     PyGC_Head finalizers;  /* objects with, & reachable from, __del__ */
     PyGC_Head *gc;
-    _PyTime_t t1 = 0;   /* initialize to prevent a compiler warning */
+    // GraalPy change: t1 usage commented out
+    // _PyTime_t t1 = 0;   /* initialize to prevent a compiler warning */
     GCState *gcstate = graalpy_get_gc_state(tstate); // GraalPy change
 
     if (GraalPyTruffle_DisableReferneceQueuePolling()) {

graalpython/com.oracle.graal.python.cext/src/listobject.c

@@ -133,7 +133,7 @@ PyTypeObject PyList_Type = {
 
 // alias for internal function, currently used in PyO3
 PyAPI_FUNC(void) _PyList_SET_ITEM(PyObject* a, Py_ssize_t b, PyObject* c) {
-    return PyList_SET_ITEM(a, b, c);
+    PyList_SET_ITEM(a, b, c);
 }
 
 static inline int

graalpython/com.oracle.graal.python.cext/src/longobject.c

@@ -888,7 +888,7 @@ PyLong_FromVoidPtr(void *p)
 {
     // GraalPy change: different implementation
     // directly do the upcall to avoid a cast to primitive and reference counting
-    return ((PyObject* (*)(void*))GraalPyLong_FromUnsignedLongLong)(p);
+    return GraalPyLong_FromUnsignedLongLong((uint64_t)p);
 }
 
 #if 0 // GraalPy change

graalpython/com.oracle.graal.python.cext/src/obmalloc.c

@@ -384,7 +384,6 @@ _GraalPyMem_PrepareAlloc(GraalPyMem_t *state, size_t size)
                 __func__, state->native_memory_gc_barrier, size, state->allocated_memory);
 
         size_t delay = 0;
-        int iteration = 0;
         for (int iteration = 0; iteration < MAX_COLLECTION_RETRIES;
                 iteration++) {
             GraalPyTruffle_TriggerGC(delay);

graalpython/com.oracle.graal.python.cext/src/unicodeobject.c

@@ -1381,7 +1381,6 @@ PyUnicode_New(Py_ssize_t size, Py_UCS4 maxchar)
 {
     // GraalPy change: different implementation
     /* add one to size for the null character */
-	int is_ascii = 0;
     if (maxchar < 128) {
         /* We intentionally use 'size' (which is one element less than the allocated array)
          * because interop users should not see the null character. */