Skip to content

Commit 2992d88

Browse files
committed
Add warning about the use of fingerprint on signature verification method
1 parent 54d1489 commit 2992d88

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ and supported by OneLogin Inc.
1010
Warning
1111
-------
1212

13+
php-saml is not affected by [201803-01](https://simplesamlphp.org/security/201803-01)
14+
1315
Update php-saml to 2.10.4, this version includes a security patch related to
1416
[signature validations on LogoutRequests/LogoutResponses](https://github.com/onelogin/php-saml/commit/949359f5cad5e1d085c4e5447d9aa8f49a6e82a1)
1517

@@ -157,6 +159,7 @@ In production, the `strict` parameter **MUST** be set as `"true"` and the
157159
something other than SHA1 (see https://shattered.io/ ). Otherwise your
158160
environment is not secure and will be exposed to attacks.
159161

162+
In production also we highly recommended to register on the settings the IdP certificate instead of using the fingerprint method. The fingerprint, is a hash, so at the end is open to a collision attack that can end on a siganture validation bypass. Other SAML toolkits deprecated that mechanism, we maintain it for compatibility and also to be used on test environment.
160163

161164
Getting started
162165
---------------
@@ -379,7 +382,8 @@ $settings = array (
379382
'x509cert' => '',
380383
/*
381384
* Instead of use the whole x509cert you can use a fingerprint in order to
382-
* validate a SAMLResponse.
385+
* validate a SAMLResponse, but we don't recommend to use that
386+
* method on production since is exploitable by a collision attack.
383387
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
384388
* or add for example the -sha256 , -sha384 or -sha512 parameter)
385389
*

settings_example.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,10 @@
101101
// Public x509 certificate of the IdP
102102
'x509cert' => '',
103103
/*
104-
* Instead of use the whole x509cert you can use a fingerprint
104+
* Instead of use the whole x509cert you can use a fingerprint in
105+
* order to validate the SAMLResponse, but we don't recommend to use
106+
* that method on production since is exploitable by a collision
107+
* attack.
105108
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
106109
* or add for example the -sha256 , -sha384 or -sha512 parameter)
107110
*

0 commit comments

Comments
 (0)