Skip to content

Commit ae967d1

Browse files
authored
Merge pull request scrapy#6475 from LucasSD/remove-debug-log-message
Remove log pollution from core.engine signal handler (scrapy#6433)
2 parents 67ab8d4 + f260f81 commit ae967d1

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

scrapy/core/engine.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
from scrapy.signalmanager import SignalManager
4040
from scrapy.utils.log import failure_to_exc_info, logformatter_adapter
4141
from scrapy.utils.misc import build_from_crawler, load_object
42-
from scrapy.utils.python import global_object_name
4342
from scrapy.utils.reactor import CallLaterOnce
4443

4544
if TYPE_CHECKING:
@@ -325,10 +324,6 @@ def _schedule_request(self, request: Request, spider: Spider) -> None:
325324
)
326325
for handler, result in request_scheduled_result:
327326
if isinstance(result, Failure) and isinstance(result.value, IgnoreRequest):
328-
logger.debug(
329-
f"Signal handler {global_object_name(handler)} dropped "
330-
f"request {request} before it reached the scheduler."
331-
)
332327
return
333328
if not self.slot.scheduler.enqueue_request(request): # type: ignore[union-attr]
334329
self.signals.send_catch_log(

tests/test_engine.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,6 @@ def signal_handler(request: Request, spider: Spider) -> None:
499499
assert scheduler.enqueued == [
500500
keep_request
501501
], f"{scheduler.enqueued!r} != [{keep_request!r}]"
502-
assert "dropped request <GET https://drop.example>" in caplog.text
503502
crawler.signals.disconnect(signal_handler, request_scheduled)
504503

505504

0 commit comments

Comments
 (0)