Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php-debugbar/php-debugbar
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tburry/php-debugbar
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 28, 2016

  1. Use included Font Awesome for debug bar control buttons 

    Replace the CSS bitmaps with Font Awesome for the minimize, maximize, close, and open buttons. When you are on a retina monitor the lower DPI buttons really stick out and since you already use Font Awesome it makes sense to use it here too.
    @tburry
    tburry committed Apr 28, 2016
    Configuration menu
    Copy the full SHA
    99514a0 View commit details
    Browse the repository at this point in the history

  2. Fix PDO erroroInfo() erasure 

    When calling TraceablePDO::query() without PDO::ERRMODE_EXCEPTION I can’t call TraceablePDO::errorInfo() because it has been reset by the internal call to PDO::getAttribute(PDO::ATTR_ERRMODE).

This PR moves the calling of PDO::getAttribute(PDO::ATTR_ERRMODE) to above the actual query so that the error information from the actual query stays on the PDO object.
    @tburry
    tburry committed Apr 28, 2016
    Configuration menu
    Copy the full SHA
    71f9706 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-pdo-errorinfo-erasure'

    @tburry
    tburry committed Apr 28, 2016
    Configuration menu
    Copy the full SHA
    06e0950 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2016

  1. Merge branch 'upstream'

    @tburry
    tburry committed May 7, 2016
    Configuration menu
    Copy the full SHA
    67961da View commit details
    Browse the repository at this point in the history
Loading