Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thegreenhouseio/angularjs-webapp-seed
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: thisgeek/angularjs-webpack-seed
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 17 files changed
  • 2 contributors

Commits on May 5, 2017

  1. migrate application to use mocha + sinon-chai testing frameworks (#1) (

    …#6)
    
    Co-authored-by: Owen Buckley <[email protected]>
    2 people authored and thescientist13 committed May 5, 2017
    Configuration menu
    Copy the full SHA
    a483c63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43451de View commit details
    Browse the repository at this point in the history

Commits on May 16, 2017

  1. prefer Array.find over Array.filter then select first item (#12) (#13)

    These changes are a refactor.
    thisgeek authored and thescientist13 committed May 16, 2017
    Configuration menu
    Copy the full SHA
    fd338c0 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2017

  1. README mentions Vagrant but repo lacks Vagrantfile (#15)

    The README.md at line 50 said "(Vagrant will do this for you)", referencing `yarn install`, but the repository has no Vagrantfile. Assuming it will not have Vagrantfile, I recommend removing this note to avoid confusion.
    thisgeek authored and thescientist13 committed May 17, 2017
    Configuration menu
    Copy the full SHA
    f0480bd View commit details
    Browse the repository at this point in the history

Commits on May 19, 2017

  1. Configuration menu
    Copy the full SHA
    0f54c9d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2017

  1. implement an example of lazy-loading (#3) (#11)

    - lazy load the user state controller and template
    - add a reference in README to lazy loading in the wiki documentation
    
    As implemented, the lazy-loading employed here leverages webpack 2's support
    for the pending dynamic import syntax. Eslint and babel now include plugins and
    configurations that accept the new syntax.
    
    Here's how it works: The dynamic import requests the files needed for the
    application's routes. It provides the promise returned by the templateProvider
    function for each route. For the controller, the approach is more indirect. At
    the time of configuration, the route knows its controller by name, but that is
    all. Within a resolve function, the ocLazyLoad service injects the module that
    registers the controller. Now, when the router looks up the controller by name
    it finds it in the registry.
    
    Note: Grouping the related imports in a common chunk requires the use of a
    "magic comment", which in turn required a webpack upgrade.
    thisgeek authored and thescientist13 committed May 23, 2017
    Configuration menu
    Copy the full SHA
    237c9ce View commit details
    Browse the repository at this point in the history

Commits on May 24, 2017

  1. Configuration menu
    Copy the full SHA
    d3bf346 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2017

  1. Configuration menu
    Copy the full SHA
    e156fee View commit details
    Browse the repository at this point in the history
Loading