Skip to content

Commit c711084

Browse files
author
Claudio
committed
fixing typed tests
1 parent 40d9b78 commit c711084

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

test/test_shortening_urls.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
#!/usr/bin/env python
22
#-*- coding:utf-8 -*-
33

4+
import socket
5+
46
from nose.tools import assert_raises
5-
from urllib2 import URLError
67
from mox import Mox
78

89
import bitly
@@ -109,7 +110,7 @@ def verifying_that_a_custom_exception_is_raised_on_timeout(api):
109110
bitly_shortening_url = 'http://api.bit.ly/shorten?login=jcfigueiredo&version=2.0.1&apiKey=R_1cf5dc0fa14c2df34261fb620bd256aa&format=json&longUrl=http%3A%2F%2Fwww.matandorobosgigantes.com'
110111

111112
mox.StubOutWithMock(httplib2.Http, "request")
112-
httplib2.Http.request(bitly_shortening_url).AndRaise(URLError('urlopen error timed out'))
113+
httplib2.Http.request(bitly_shortening_url).AndRaise(socket.timeout('timed out'))
113114

114115
url_to_be_shortened = 'http://www.matandorobosgigantes.com'
115116

@@ -126,13 +127,13 @@ def verifying_that_urlerror_exceptions_are_reraised_but_timeout_exceptions(api):
126127
bitly_shortening_url = 'http://api.bit.ly/shorten?login=jcfigueiredo&version=2.0.1&apiKey=R_1cf5dc0fa14c2df34261fb620bd256aa&format=json&longUrl=http%3A%2F%2Fwww.matandorobosgigantes.com'
127128

128129
mox.StubOutWithMock(httplib2.Http, "request")
129-
httplib2.Http.request(bitly_shortening_url).AndRaise(URLError('something different from timeout'))
130+
httplib2.Http.request(bitly_shortening_url).AndRaise(socket.timeout('something different from timeout'))
130131

131132
url_to_be_shortened = 'http://www.matandorobosgigantes.com'
132133

133134
try:
134135
mox.ReplayAll()
135-
assert_raises(URLError, api.shorten, url_to_be_shortened)
136+
assert_raises(socket.timeout, api.shorten, url_to_be_shortened)
136137
mox.VerifyAll()
137138
finally:
138139
mox.UnsetStubs()

0 commit comments

Comments
 (0)