Skip to content

Commit 20abf37

Browse files
author
epriestley
committed
Fix a lookup issue in Owners
Summary: Fixes T4477. Sort of winging this but it's probably the right fix? One error in T4477. One error via email: ``` [2014-04-15 17:44:34] ERROR 8: Undefined index: /some_index/ at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:213] #0 PhabricatorOwnersPackage::findLongestPathsPerPackage(Array of size 3 starting with: { 0 => Array of size 3 starting with: { id => 5 } }, Array of size 8 starting with: { / => Array of size 2 starting with: { /some_index/some_file.py => true } }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:170] #1 PhabricatorOwnersPackage::loadPackagesForPaths(Object PhabricatorRepository, Array of size 2 starting with: { 0 => /some_index/some_file.py }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:119] ... ``` Test Plan: Will make @Zeeg do it. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley, zeeg Maniphest Tasks: T4477 Differential Revision: https://secure.phabricator.com/D8779
1 parent c845b75 commit 20abf37

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/applications/owners/storage/PhabricatorOwnersPackage.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ public static function findLongestPathsPerPackage(array $rows, array $paths) {
210210
$remove = array();
211211
foreach ($package_paths as $package_path) {
212212
if ($package_path['excluded']) {
213-
$remove += $relevant_paths[$package_path['path']];
213+
$remove += idx($relevant_paths, $package_path['path'], array());
214214
unset($relevant_paths[$package_path['path']]);
215215
}
216216
}

0 commit comments

Comments
 (0)