unescape always to_s. test

Author: Jerry Cheung

lib/net/ldap/filter.rb

@@ -644,18 +644,9 @@ def match(entry)
   end
 
   ##
-  # If the argument is a string, converts escaped characters (e.g., "\\28") to unescaped characters.
-  # If the argument is a number, just return as-is.
-  # Otherwise, an exception is thrown and the rhs argument is rejected.
-  # ("(").
+  # Converts escaped characters (e.g., "\\28") to unescaped characters
   def unescape(right)
-    if defined? right.gsub
-      right.gsub(/\\([a-fA-F\d]{2})/) { [$1.hex].pack("U") }
-    elsif right.is_a? Fixnum
-      right.to_s
-    else
-      raise ArgumentError, "Did not know how to convert argument \"#{right}\" into the rhs of an LDAP filter"
-    end
+    right.to_s.gsub(/\\([a-fA-F\d]{2})/) { [$1.hex].pack("U") }
   end
   private :unescape
 

test/test_filter.rb

@@ -215,4 +215,9 @@ def test_parse_ber_escapes_characters
     filter = Net::LDAP::Filter.parse_ber(ber.read_ber(Net::LDAP::AsnSyntax))
     assert_equal "(objectclass=#{escaped}*#{escaped}*#{escaped})", filter.to_s
   end
+
+  def test_unescape_fixnums
+    filter = Net::LDAP::Filter.eq("objectclass", 3)
+    assert_equal "\xA3\x10\x04\vobjectclass\x04\x013".b, filter.to_ber
+  end
 end