setQueryParams should also drop the query, close AsyncHttpClient#696

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/RequestBuilderBase.java

@@ -438,16 +438,17 @@ public T setBody(BodyGenerator bodyGenerator) {
     }
 
     public T addQueryParam(String name, String value) {
-        if (queryParams == null) {
+        if (queryParams == null)
             queryParams = new ArrayList<Param>(1);
-        }
         queryParams.add(new Param(name, value));
         return derived.cast(this);
     }
 
-    public T addQueryParams(List<Param> queryParams) {
-        for (Param queryParam: queryParams)
-            addQueryParam(queryParam.getName(), queryParam.getValue());
+    public T addQueryParams(List<Param> params) {
+        if (queryParams == null)
+            queryParams = params;
+        else
+            queryParams.addAll(params);
         return derived.cast(this);
     }
 
@@ -469,6 +470,9 @@ public T setQueryParams(Map<String, List<String>> map) {
     }
 
     public T setQueryParams(List<Param> params) {
+        // reset existing query
+        if (isNonEmpty(request.uri.getQuery()))
+            request.uri = request.uri.withNewQuery(null);
         queryParams = params;
         return derived.cast(this);
     }