Cache url inside UriComponents, close AsyncHttpClient#688

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/uri/UriComponents.java

@@ -41,6 +41,7 @@ public static UriComponents create(UriComponents context, final String originalU
     private final int port;
     private final String query;
     private final String path;
+    private String url;
 
     public UriComponents(String scheme,//
             String userInfo,//
@@ -91,19 +92,22 @@ public URI toURI() throws URISyntaxException {
     }
 
     public String toUrl() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(scheme).append("://");
-        if (userInfo != null)
-            sb.append(userInfo).append('@');
-        sb.append(host);
-        if (port != -1)
-            sb.append(':').append(port);
-        if (path != null)
-            sb.append(path);
-        if (query != null)
-            sb.append('?').append(query);
-
-        return sb.toString();
+        if (url == null) {
+            StringBuilder sb = new StringBuilder();
+            sb.append(scheme).append("://");
+            if (userInfo != null)
+                sb.append(userInfo).append('@');
+            sb.append(host);
+            if (port != -1)
+                sb.append(':').append(port);
+            if (path != null)
+                sb.append(path);
+            if (query != null)
+                sb.append('?').append(query);
+
+            url = sb.toString();
+        }
+        return url;
     }
 
     public String toRelativeUrl() {

providers/netty/src/main/java/org/asynchttpclient/providers/netty/handler/Protocol.java

@@ -125,7 +125,7 @@ protected boolean exitAfterHandlingRedirect(//
                     final String initialPoolKey = channelManager.getPoolKey(future);
 
                     future.setURI(uri);
-                    String newUrl = uri.toString();
+                    String newUrl = uri.toUrl();
                     if (request.getURI().getScheme().startsWith(WEBSOCKET)) {
                         newUrl = newUrl.replaceFirst(HTTP, WEBSOCKET);
                     }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyRequestFactory.java

@@ -77,7 +77,7 @@ private String requestUri(UriComponents uri, ProxyServer proxyServer, HttpMethod
             return getAuthority(uri);
 
         else if (proxyServer != null && !(useProxyConnect(uri) && config.isUseRelativeURIsWithConnectProxies()))
-            return uri.toString();
+            return uri.toUrl();
 
         else {
             String path = getNonEmptyPath(uri);