NettyRequestSender.retry: future isn't null

Author: Stephane Landelle

providers/netty/src/main/java/org/asynchttpclient/providers/netty/handler/Processor.java

@@ -118,7 +118,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
             if (future.isDone())
                 channelManager.closeChannel(channel);
 
-            else if (!requestSender.retry(future, channel))
+            else if (!requestSender.retry(future))
                 requestSender.abort(future, REMOTELY_CLOSED_EXCEPTION);
         }
     }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyConnectListener.java

@@ -129,7 +129,7 @@ public void onFutureFailure(Channel channel, Throwable cause) {
                 && cause != null//
                 && (cause instanceof ClosedChannelException || future.getState() != NettyResponseFuture.STATE.NEW || StackTraceInspector.abortOnDisconnectException(cause))) {
 
-            if (requestSender.retry(future, channel)) {
+            if (requestSender.retry(future)) {
                 return;
             }
         }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyRequestSender.java

@@ -403,25 +403,19 @@ public void abort(NettyResponseFuture<?> future, Throwable t) {
         if (!future.isDone()) {
             LOGGER.debug("Aborting Future {}\n", future);
             LOGGER.debug(t.getMessage(), t);
+            future.abort(t);
         }
-
-        future.abort(t);
     }
 
-    public boolean retry(NettyResponseFuture<?> future, Channel channel) {
+    public boolean retry(NettyResponseFuture<?> future) {
 
         if (isClosed())
             return false;
 
-        channelManager.removeAll(channel);
-
-        if (future == null) {
-            Object attribute = Channels.getAttribute(channel);
-            if (attribute instanceof NettyResponseFuture)
-                future = (NettyResponseFuture<?>) attribute;
-        }
+        // FIXME what is this for???
+        //channelManager.removeAll(channel);
 
-        if (future != null && future.canBeReplayed()) {
+        if (future.canBeReplayed()) {
             future.setState(NettyResponseFuture.STATE.RECONNECTED);
             future.getAndSetStatusReceived(false);