Skip to content

Commit 453b5cd

Browse files
authored
Update create_image_from_disk() to specify only the instance_name instead of the ful… (GoogleCloudPlatform#11112)
* implemented fix for instance name argument on create_image_from_disk() * Revert "implemented fix for instance name argument on create_image_from_disk()" This reverts commit 3b396bd. * reimplemented create _image_from_disk() fix * regenerated snippet
1 parent 583de9f commit 453b5cd

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

compute/client_library/ingredients/images/create.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,9 @@ def create_image_from_disk(
6464
disk = disk_client.get(project=project_id, zone=zone, disk=source_disk_name)
6565

6666
for disk_user in disk.users:
67+
instance_name = disk_user.split("/")[-1]
6768
instance = instance_client.get(
68-
project=project_id, zone=zone, instance=disk_user
69+
project=project_id, zone=zone, instance=instance_name
6970
)
7071
if instance.status in STOPPED_MACHINE_STATUS:
7172
continue

compute/client_library/snippets/images/create.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,9 @@ def create_image_from_disk(
118118
disk = disk_client.get(project=project_id, zone=zone, disk=source_disk_name)
119119

120120
for disk_user in disk.users:
121+
instance_name = disk_user.split("/")[-1]
121122
instance = instance_client.get(
122-
project=project_id, zone=zone, instance=disk_user
123+
project=project_id, zone=zone, instance=instance_name
123124
)
124125
if instance.status in STOPPED_MACHINE_STATUS:
125126
continue

0 commit comments

Comments
 (0)