Merge pull request #10 from topcoder-platform/features/pureV5Design

support checkpoint prizes

Author: rootelement

config/default.js

@@ -43,6 +43,7 @@ module.exports = {
   PAYMENT_STATUS_ID: process.env.PAYMENT_STATUS_ID || 55, // on hold
   MODIFICATION_RATIONALE_ID: process.env.MODIFICATION_RATIONALE_ID || 1,
   WINNER_PAYMENT_TYPE_ID: process.env.WINNER_PAYMENT_TYPE_ID || 72,
+  CHECKPOINT_WINNER_PAYMENT_TYPE_ID: process.env.CHECKPOINT_WINNER_PAYMENT_TYPE_ID || 64,
   COPILOT_PAYMENT_TYPE_ID: process.env.COPILOT_PAYMENT_TYPE_ID || 74,
 
   V5_PAYMENT_DETAIL_STATUS_REASON_ID: process.env.V5_PAYMENT_DETAIL_STATUS_REASON_ID || 500,

src/app.js

@@ -44,9 +44,9 @@ const dataHandler = (messageSet, topic, partition) => Promise.each(messageSet, a
     return
   }
 
-  // Currently only process payments for challenges with `legacy.pureV5Task: true`
-  if (!_.get(messageJSON.payload, 'legacy.pureV5Task', false)) {
-    logger.info(`Challenge Legacy Object ${JSON.stringify(_.get(messageJSON.payload, 'legacy'))} does not have legacy.pureV5Task: true`)
+  // Currently only process payments for challenges with `legacy.pureV5Task: true` or `legacy.pureV5: true`
+  if (!_.get(messageJSON.payload, 'legacy.pureV5Task', false) && !_.get(messageJSON.payload, 'legacy.pureV5', false)) {
+    logger.info(`Challenge Legacy Object ${JSON.stringify(_.get(messageJSON.payload, 'legacy'))} does not have legacy.pureV5Task: true or legacy.pureV5: true`)
     await consumer.commitOffset({ topic, partition, offset: m.offset })
     return
   }

src/services/processorService.js

@@ -40,8 +40,11 @@ async function processUpdate(message) {
   // add winner payment
   try {
     const winnerPrizes = _.get(_.find(message.payload.prizeSets, ['type', 'placement']), 'prizes', [])
+    const checkpointPrizes = _.get(_.find(message.payload.prizeSets, ['type', 'checkpoint']), 'prizes', [])
     // const winnerPaymentDesc = _.get(_.find(message.payload.prizeSets, ['type', 'placement']), 'description', '')
-    const winnerMembers = _.sortBy(_.get(message.payload, 'winners', []), ['placement'])
+    //` w => w.type === 'placement' || _.isUndefined(w.type)` is used here to support challenges where the type is not set (old data or other tracks that only have placements)
+    const winnerMembers = _.sortBy(_.filter(_.get(message.payload, 'winners', []), w => w.type === 'placement' || _.isUndefined(w.type)), ['placement'])
+    const checkpointWinnerMembers = _.sortBy(_.filter(_.get(message.payload, 'winners', []), w => w.type === 'checkpoint'), ['placement'])
     if (_.isEmpty(winnerPrizes)) {
       logger.warn(`For challenge ${v5ChallengeId}, no winner payment avaiable`)
     } else if (winnerPrizes.length !== winnerMembers.length) {
@@ -52,7 +55,7 @@ async function processUpdate(message) {
           const payment = _.assign({
             memberId: winnerMembers[i - 1].userId,
             amount: winnerPrizes[i - 1].value,
-            desc: `Task - ${message.payload.name} - ${i} Place`,
+            desc: `Payment - ${message.payload.name} - ${i} Place`,
             typeId: config.WINNER_PAYMENT_TYPE_ID
           }, basePayment)
 
@@ -69,6 +72,33 @@ async function processUpdate(message) {
       }
     }
 
+    if (_.isEmpty(checkpointPrizes)) {
+      logger.warn(`For challenge ${v5ChallengeId}, no checkpoint winner payment avaiable`)
+    } else if (checkpointPrizes.length !== checkpointWinnerMembers.length) {
+      logger.error(`For challenge ${v5ChallengeId}, there is ${checkpointPrizes.length} user prizes but ${checkpointWinnerMembers.length} winners`)
+    } else {
+      try {
+        for (let i = 1; i <= checkpointPrizes.length; i++) {
+          const payment = _.assign({
+            memberId: checkpointWinnerMembers[i - 1].userId,
+            amount: checkpointPrizes[i - 1].value,
+            desc: `Payment - ${message.payload.name} - ${i} Place`,
+            typeId: config.CHECKPOINT_WINNER_PAYMENT_TYPE_ID
+          }, basePayment)
+
+          const paymentExists = await paymentService.paymentExists(payment)
+          logger.debug(`Payment Exists Response: ${JSON.stringify(paymentExists)}`)
+          if(!paymentExists || paymentExists.length === 0) {
+            await paymentService.createPayment(payment)
+          } else {
+            logger.error(`Payment Exists for ${v5ChallengeId}, skipping - ${JSON.stringify(paymentExists)}`)
+          }
+        }
+      } catch (error) {
+        logger.error(`For challenge ${v5ChallengeId}, add checkpoint winner payments error: ${error}`)
+      }
+    }
+
     // add copilot payment
     const copilotId = await helper.getCopilotId(message.payload.id)
     const copilotAmount = _.get(_.head(_.get(_.find(message.payload.prizeSets, ['type', 'copilot']), 'prizes', [])), 'value')
@@ -124,7 +154,8 @@ processUpdate.schema = {
       winners: Joi.array().items(Joi.object({
         userId: Joi.number().integer().positive().required(),
         handle: Joi.string(),
-        placement: Joi.number().integer().positive().required()
+        placement: Joi.number().integer().positive().required(),
+        type: Joi.string().valid(['placement', 'checkpoint'])
       }).unknown(true)),
       type: Joi.string().required(),
       status: Joi.string().required(),