Ignore AV Scan reviews

Author: callmekatootie

config/default.js

@@ -21,6 +21,7 @@ module.exports = {
 
   LEADERBOARD_API_URL: process.env.LEADERBOARD_API_URL || 'https://api.topcoder-dev.com/v5/leaderboard',
   SUBMISSION_API_URL: process.env.SUBMISSION_API_URL || 'https://api.topcoder-dev.com/v5/submissions',
+  REVIEW_TYPE_URL: process.env.REVIEW_TYPE_URL || 'https://api.topcoder-dev.com/v5/reviewTypes',
 
   AUTH0_URL: process.env.AUTH0_URL,
   AUTH0_AUDIENCE: process.env.AUTH0_AUDIENCE,

src/app.js

@@ -8,6 +8,7 @@ const logger = require('./common/logger')
 const Kafka = require('no-kafka')
 const healthcheck = require('topcoder-healthcheck-dropin')
 const ProcessorService = require('./services/ProcessorService')
+const helper = require('./common/helper')
 
 // start Kafka consumer
 logger.info('Start Kafka consumer.')
@@ -19,7 +20,7 @@ if (config.KAFKA_CLIENT_CERT && config.KAFKA_CLIENT_CERT_KEY) {
 const consumer = new Kafka.GroupConsumer(options)
 
 // data handler
-const dataHandler = (messageSet, topic, partition) => Promise.each(messageSet, (m) => {
+const dataHandler = (messageSet, topic, partition) => Promise.each(messageSet, async (m) => {
   const message = m.message.value.toString('utf8')
   logger.info(`Handle Kafka event message; Topic: ${topic}; Partition: ${partition}; Offset: ${
     m.offset}; Message: ${message}.`)
@@ -46,6 +47,13 @@ const dataHandler = (messageSet, topic, partition) => Promise.each(messageSet, (
     return
   }
 
+  const avScanTypeId = await helper.getreviewTypeId('AV Scan')
+
+  if (messageJSON.payload.typeId === avScanTypeId) {
+    logger.debug(`Ignoring AV Scan reviews from topic ${messageJSON.topic}`)
+    return false
+  }
+
   return (async () => {
     switch (topic) {
       case config.CREATE_DATA_TOPIC:

src/common/helper.js

@@ -9,6 +9,9 @@ const m2mAuth = require('tc-core-library-js').auth.m2m
 
 const m2m = m2mAuth(_.pick(config, ['AUTH0_URL', 'AUTH0_AUDIENCE', 'TOKEN_CACHE_TIME', 'AUTH0_PROXY_SERVER_URL']))
 
+// Variable to cache reviewTypes from Submission API
+const reviewTypes = {}
+
 /*
  * Function to get M2M token
  * @returns {Promise}
@@ -55,6 +58,25 @@ const reqToAPI = async (reqType, path, reqBody) => {
   })
 }
 
+/*
+ * Function to get reviewTypeId from Name
+ * @param {String} reviewTypeName Name of the reviewType
+ * @returns {String} reviewTypeId
+ */
+const getreviewTypeId = async (reviewTypeName) => {
+  if (!reviewTypes[reviewTypeName]) {
+    // Get review type id from Submission API
+    const response = await reqToAPI('GET', `${config.REVIEW_TYPE_URL}?name=${reviewTypeName}`)
+    if (response.body && response.body.length !== 0) {
+      reviewTypes[reviewTypeName] = response.body[0].id
+    } else {
+      reviewTypes[reviewTypeName] = null
+    }
+  }
+  return reviewTypes[reviewTypeName]
+}
+
 module.exports = {
-  reqToAPI
+  reqToAPI,
+  getreviewTypeId
 }

test/common/prepare.js

@@ -4,7 +4,7 @@
 
 const nock = require('nock')
 const prepare = require('mocha-prepare')
-const { submissionAPIResponse } = require('./testData')
+const { submissionAPIResponse, reviewTypesResponse } = require('./testData')
 
 prepare(function (done) {
   nock(/\.com/)
@@ -27,6 +27,8 @@ prepare(function (done) {
     .reply(200)
     .delete('/v5/leaderboard/review/49871146-eb0a-4d0e-ab9a-adc94018c5da')
     .reply(204)
+    .get('/v5/reviewTypes?name=AV%20Scan')
+    .reply(200, reviewTypesResponse)
 
   done()
 }, function (done) {

test/common/testData.js

@@ -116,7 +116,16 @@ const submissionAPIResponse = [
   }
 ]
 
+const reviewTypesResponse = [
+  {
+    'name': 'AV Scan',
+    'id': '6da98d0f-e663-4539-8507-cd6c9e0e56d8',
+    'isActive': true
+  }
+]
+
 module.exports = {
   submissionAPIResponse,
-  testTopics
+  testTopics,
+  reviewTypesResponse
 }