moving name to env var

cwdcwd · cwdcwd · commit db9e9b72a26f · 2019-11-08T19:56:18.000-05:00
diff --git a/config/default.js b/config/default.js
@@ -22,6 +22,7 @@ module.exports = {
   LEADERBOARD_API_URL: process.env.LEADERBOARD_API_URL || 'https://api.topcoder-dev.com/v5/leaderboard',
   SUBMISSION_API_URL: process.env.SUBMISSION_API_URL || 'https://api.topcoder-dev.com/v5/submissions',
   REVIEW_TYPE_URL: process.env.REVIEW_TYPE_URL || 'https://api.topcoder-dev.com/v5/reviewTypes',
+  AV_SCAN_NAME: process.env.AV_SCAN_NAME || 'AV Scan',
 
   AUTH0_URL: process.env.AUTH0_URL,
   AUTH0_AUDIENCE: process.env.AUTH0_AUDIENCE,
diff --git a/src/app.js b/src/app.js
@@ -47,7 +47,7 @@ const dataHandler = (messageSet, topic, partition) => Promise.each(messageSet, a
     return
   }
 
-  const avScanTypeId = await helper.getreviewTypeId('AV Scan')
+  const avScanTypeId = await helper.getreviewTypeId(config.AV_SCAN_NAME)
 
   if (messageJSON.payload.typeId === avScanTypeId) {
     logger.debug(`Ignoring AV Scan reviews from topic ${messageJSON.topic}`)

-Original file line number
+Diff line change
   LEADERBOARD_API_URL: process.env.LEADERBOARD_API_URL || 'https://api.topcoder-dev.com/v5/leaderboard',
   SUBMISSION_API_URL: process.env.SUBMISSION_API_URL || 'https://api.topcoder-dev.com/v5/submissions',
   REVIEW_TYPE_URL: process.env.REVIEW_TYPE_URL || 'https://api.topcoder-dev.com/v5/reviewTypes',
 +  AV_SCAN_NAME: process.env.AV_SCAN_NAME || 'AV Scan',
   AUTH0_URL: process.env.AUTH0_URL,
   AUTH0_AUDIENCE: process.env.AUTH0_AUDIENCE,
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ const dataHandler = (messageSet, topic, partition) => Promise.each(messageSet, a`
`47`	`47`	`return`
`48`	`48`	`}`
`49`	`49`
`50`		`- const avScanTypeId = await helper.getreviewTypeId('AV Scan')`
	`50`	`+ const avScanTypeId = await helper.getreviewTypeId(config.AV_SCAN_NAME)`
`51`	`51`
`52`	`52`	`if (messageJSON.payload.typeId === avScanTypeId) {`
`53`	`53`	logger.debug(`Ignoring AV Scan reviews from topic ${messageJSON.topic}`)