Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 82a3a04

Browse files
PROD-1551 #comment host config files in source control rather than in S3;
add ADR-01 to describe the decision #time 15m
1 parent 8b64c8d commit 82a3a04

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

config/constants.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ module.exports = Object.freeze({
22
APP_CONFIG: [
33
{
44
'appEnv': 'dev',
5-
'mfeConfigPath': 'https://tc-public-static-files.topcoder-dev.com/micro-frontends/micro-frontends-config-development.json',
5+
'mfeConfigPath': '/micro-frontends-config-development.json',
66
'mfeIndexPath': '/index.html',
7-
'mfeRoutesPath': 'https://tc-public-static-files.topcoder-dev.com/micro-frontends/micro-frontends-routes-development.txt'
7+
'mfeRoutesPath': '/micro-frontends-routes-development.txt'
88
},
99
{
1010
'appEnv': 'prod',
11-
'mfeConfigPath': 'https://tc-public-static-files.topcoder.com/micro-frontends/micro-frontends-config-production.json',
11+
'mfeConfigPath': '/micro-frontends-config-production.json',
1212
'mfeIndexPath': '/index.html',
13-
'mfeRoutesPath': 'https://tc-public-static-files.topcoder.com/micro-frontends/micro-frontends-routes-production.txt'
13+
'mfeRoutesPath': '/micro-frontends-routes-production.txt'
1414
},
1515
{
1616
'appEnv': 'local-multi',

config/docs/adr-01.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# ADR-01 2022-05-06
2+
3+
4+
5+
We moved the source of the config json and routes txt files to source control
6+
from the S3 server in order to simplify modifications.
7+
8+
There is no sensitive info in these files, so there is no need to host
9+
them any differently in prod or dev envs.

0 commit comments

Comments
 (0)