fix: "User is required" error when fetching settings

dhruvit-r · dhruvit-r · commit 8b4e11bb3007 · 2023-10-03T09:38:12.000+05:30
diff --git a/src/services/UserService.js b/src/services/UserService.js
@@ -52,8 +52,8 @@ async function getUserSetting(handle) {
   if (gitlabMapping && gitlabMapping.gitlabUsername) {
     const gitlab = await dbHelper.queryOneUserByType(
       User, gitlabMapping.gitlabUsername, constants.USER_TYPES.GITLAB);
-    const gitlabService = await GitlabService.create(gitlab);
-    if (!_.isNil(gitlabService.user)) {
+      if (!_.isNil(gitlab)) {
+      const gitlabService = await GitlabService.create(gitlab);
       users.push(gitlabService.user);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,8 @@ async function getUserSetting(handle) {`
`52`	`52`	`if (gitlabMapping && gitlabMapping.gitlabUsername) {`
`53`	`53`	`const gitlab = await dbHelper.queryOneUserByType(`
`54`	`54`	`User, gitlabMapping.gitlabUsername, constants.USER_TYPES.GITLAB);`
`55`		`- const gitlabService = await GitlabService.create(gitlab);`
`56`		`- if (!_.isNil(gitlabService.user)) {`
	`55`	`+ if (!_.isNil(gitlab)) {`
	`56`	`+ const gitlabService = await GitlabService.create(gitlab);`
`57`	`57`	`users.push(gitlabService.user);`
`58`	`58`	`}`
`59`	`59`	`}`