Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$20] Get js error and crash app after searching and click on "Create" button #116

Closed
HongHT opened this issue Jul 12, 2020 · 8 comments
Closed
Assignees
Labels
bug Something isn't working medium priority Not a roadblock to release but must be addressed at some point tcx_Assigned tcx_FixAccepted tcx_Paid

Comments

@HongHT
Copy link

HongHT commented Jul 12, 2020

Reproduction Steps:

  1. Open the application
  2. On "Search" tab, click on "+" icon inside any profiles
  3. Enter any characters in Search box then Click on "Create" button
  4. Observe the result

Screenshot/screencast:
https://drive.google.com/drive/folders/1taqM4PrT2NNP4740QY1d0Rb9ixCJi6aN?fbclid=IwAR2pD3gYGvZcsncY7T4ewgF1IEi-61WkcDjy_Rs7N6WIH86KnWvGCSpOFdU

Actual Result: Get js error and crash app after searching and click on "Create" button

Expected Result: Should work well without any broken.

Device/OS: Laptop | Windows 10 (64bit)

Browser Information: IE11 , Google Chrome 83.0.4103.116, Firefox 78.0.2

@callmekatootie
Copy link
Collaborator

valid bug. Related to #93, but in this case, it appears that the group name should be more than 3 characters

@wdprice
Copy link

wdprice commented Jul 20, 2020

@callmekatootie ideally error handling on the groups API would help here, but we can also validate on the front end if only the 3 character minimum are the issue.

@wdprice wdprice added this to the v1.0 - Initial Launch milestone Jul 20, 2020
@callmekatootie
Copy link
Collaborator

Ok. I will go with the former, which will help debug issues better (and even for the front end user to understand their errors)

Expected: For both Add Group modal and Groups Tab page, when we make a request to create a new group, we get back an error message from the groups api (if there is an error) - display the error message using the browser's alert() function that the api returns (only in case of error)

@callmekatootie callmekatootie changed the title Get js error and crash app after searching and click on "Create" button [$20] Get js error and crash app after searching and click on "Create" button Jul 21, 2020
@callmekatootie
Copy link
Collaborator

Update - we do display error now. But only specific errors.

The expected fix is that if the api request returns with an error status code AND has a message attribute, display the message attribute value in the alert() function.

Example to test with - try entering a group name more than 150 characters or less than 3 characters...

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 24, 2020

Contest https://www.topcoder.com/challenges/30134137 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@phongnt phongnt self-assigned this Jul 24, 2020
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 24, 2020

Contest https://www.topcoder.com/challenges/30134137 has been updated - it has been assigned to genycopedison.

This is an automated message for lazybaer via Topcoder X

phongnt added a commit that referenced this issue Jul 24, 2020
@phongnt
Copy link
Collaborator

phongnt commented Jul 24, 2020

image

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 24, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30134137

This is an automated message for lazybaer via Topcoder X

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working medium priority Not a roadblock to release but must be addressed at some point tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Development

No branches or pull requests

5 participants