[GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky

https://bugs.webkit.org/show_bug.cgi?id=168194

Reviewed by Carlos Garcia Campos.

Fix an assertion and unskip the test. The order that form controls are associated is not
guaranteed.

* Scripts/run-gtk-tests:
(GtkTestRunner):
* TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(didAssociateFormControlsCallback):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@226326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Tools/ChangeLog

@@ -1,3 +1,18 @@
+2018-01-02  Michael Catanzaro  <[email protected]>
+
+        [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=168194
+
+        Reviewed by Carlos Garcia Campos.
+
+        Fix an assertion and unskip the test. The order that form controls are associated is not
+        guaranteed.
+
+        * Scripts/run-gtk-tests:
+        (GtkTestRunner):
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
+        (didAssociateFormControlsCallback):
+
 2018-01-02  Alex Christensen  <[email protected]>
 
         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI

Tools/Scripts/run-gtk-tests

@@ -41,7 +41,6 @@ class GtkTestRunner(TestRunner):
         SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580),
         SkippedTest("WebKit2Gtk/TestPrinting", "/webkit2/WebKitPrintOperation/custom-widget", "Test is flaky", 168196),
         SkippedTest("WebKit2Gtk/TestWebViewEditor", "/webkit2/WebKitWebView/editable/editable", "Test hits an assertion in Debug builds", 151654, "Debug"),
-        SkippedTest("WebKit2Gtk/TestWebExtensions", "/webkit2/WebKitWebExtension/form-controls-associated-signal", "Test is flaky", 168194),
         SkippedTest("WebKit2Gtk/TestWebExtensions", "/webkit2/WebKitWebView/install-missing-plugins-permission-request", "Test times out", 147822),
         SkippedTest("WebKit/TestWebKit", "WebKit.MouseMoveAfterCrash", "Test is flaky", 85066),
         SkippedTest("WebKit/TestWebKit", "WebKit.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066),

Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp

@@ -223,7 +223,7 @@ static void didAssociateFormControlsCallback(GDBusConnection*, const char*, cons
 {
     const char* formIds;
     g_variant_get(result, "(&s)", &formIds);
-    g_assert(!g_strcmp0(formIds, FORM_ID FORM2_ID) || !g_strcmp0(formIds, INPUT_ID));
+    g_assert(!g_strcmp0(formIds, FORM_ID FORM2_ID) || !g_strcmp0(formIds, FORM2_ID FORM_ID) || !g_strcmp0(formIds, INPUT_ID));
 
     test->quitMainLoop();
 }