Skip to content

Commit 1c35713

Browse files
Remove Alternative Presentation Button
https://bugs.webkit.org/show_bug.cgi?id=180500 <rdar://problem/35891047> Reviewed by Simon Fraser. We no longer need the alternative presentation button. .: * Source/cmake/OptionsMac.cmake: * Source/cmake/WebKitFeatures.cmake: * Source/cmake/tools/vsprops/FeatureDefines.props: * Source/cmake/tools/vsprops/FeatureDefinesCairo.props: Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: Source/WebCore: * Configurations/FeatureDefines.xcconfig: * DerivedSources.make: * English.lproj/Localizable.strings: * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * dom/Element.h: * editing/Editor.cpp: (WebCore::Editor::clear): (WebCore::Editor::substituteWithAlternativePresentationButton): Deleted. (WebCore::Editor::removeAlternativePresentationButton): Deleted. (WebCore::Editor::elementsReplacedByAlternativePresentationButton): Deleted. (WebCore::Editor::didInsertAlternativePresentationButtonElement): Deleted. (WebCore::Editor::didRemoveAlternativePresentationButtonElement): Deleted. * editing/Editor.h: * editing/cocoa/AlternativePresentationButtonSubstitution.cpp: Removed. * editing/cocoa/AlternativePresentationButtonSubstitution.h: Removed. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): (WebCore::HTMLInputElement::parseAttribute): (WebCore::HTMLInputElement::willAttachRenderers): (WebCore::HTMLInputElement::alternativePresentationButtonElement const): Deleted. (WebCore::HTMLInputElement::setTypeWithoutUpdatingAttribute): Deleted. (WebCore::HTMLInputElement::createInputType): Deleted. * html/HTMLInputElement.h: * html/InputType.h: (WebCore::InputType::alternativePresentationButtonElement const): Deleted. * html/InputTypeNames.cpp: (WebCore::InputTypeNames::alternativePresentationButton): Deleted. * html/InputTypeNames.h: * html/shadow/cocoa/AlternativePresentationButtonElement.cpp: Removed. * html/shadow/cocoa/AlternativePresentationButtonElement.h: Removed. * html/shadow/cocoa/AlternativePresentationButtonInputType.cpp: Removed. * html/shadow/cocoa/AlternativePresentationButtonInputType.h: Removed. * page/ChromeClient.h: * platform/LocalizedStrings.cpp: (WebCore::AXAlternativePresentationButtonLabel): Deleted. (WebCore::alternativePresentationButtonTitle): Deleted. (WebCore::alternativePresentationButtonSubtitle): Deleted. * platform/LocalizedStrings.h: * testing/Internals.cpp: (WebCore::Internals::substituteWithAlternativePresentationButton): Deleted. (WebCore::Internals::removeAlternativePresentationButton): Deleted. (WebCore::Internals::elementsReplacedByAlternativePresentationButton): Deleted. * testing/Internals.h: * testing/Internals.idl: Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: Source/WebKit: * Configurations/FeatureDefines.xcconfig: * UIProcess/API/APIUIClient.h: (API::UIClient::didClickAlternativePresentationButton): Deleted. * UIProcess/API/C/WKPageUIClient.h: * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: * UIProcess/Cocoa/UIDelegate.h: * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::UIDelegate::UIClient::didClickAlternativePresentationButton): Deleted. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleAutoFillButtonClick): (WebKit::WebPageProxy::handleAlternativePresentationButtonClick): Deleted. * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h: (API::InjectedBundle::PageUIClient::didClickAutoFillButton): (API::InjectedBundle::PageUIClient::didClickAlternativePresentationButton): Deleted. * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm: (-[WKWebProcessPlugInFrame substituteElements:withAlternativePresentationButtonWithIdentifier:]): Deleted. (-[WKWebProcessPlugInFrame removeAlternativePresentationButton:]): Deleted. (-[WKWebProcessPlugInFrame elementsReplacedByAlternativePresentationButtonWithIdentifier:]): Deleted. * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h: * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameFocus): (WKBundleSubstituteWithAlternativePresentationButton): Deleted. (WKBundleRemoveAlternativePresentationButton): Deleted. (WKBundleElementsReplacedByAlternativePresentationButton): Deleted. * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: * WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h: * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::didClickAlternativePresentationButton): Deleted. * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::handleAlternativePresentationButtonClick): Deleted. * WebProcess/WebCoreSupport/WebChromeClient.h: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/ClickAlternativePresentationButton.mm: Removed. * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: (TEST): (-[AlternativePresentationButtonDelegate _webView:didClickAlternativePresentationButtonWithUserInfo:]): Deleted. (-[AlternativePresentationButtonDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted. LayoutTests: * TestExpectations: * accessibility/alternative-presentation-button-expected.txt: Removed. * accessibility/alternative-presentation-button-input-type-expected.txt: Removed. * accessibility/alternative-presentation-button-input-type.html: Removed. * accessibility/alternative-presentation-button.html: Removed. * fast/forms/alternative-presentation-button/replace-and-remove-expected.html: Removed. * fast/forms/alternative-presentation-button/replace-and-remove.html: Removed. * fast/forms/alternative-presentation-button/replaced-elements-expected.txt: Removed. * fast/forms/alternative-presentation-button/replaced-elements.html: Removed. * fast/forms/alternative-presentation-button/replacement-expected.txt: Removed. * fast/forms/alternative-presentation-button/replacement.html: Removed. * platform/gtk/TestExpectations: * platform/ios/TestExpectations: * platform/ios/fast/forms/alternative-presentation-button/replacement-expected.txt: Removed. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@226189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 88219c0 commit 1c35713

File tree

81 files changed

+255
-1918
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

81 files changed

+255
-1918
lines changed

ChangeLog

+15
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
2017-12-20 Daniel Bates <[email protected]>
2+
3+
Remove Alternative Presentation Button
4+
https://bugs.webkit.org/show_bug.cgi?id=180500
5+
<rdar://problem/35891047>
6+
7+
Reviewed by Simon Fraser.
8+
9+
We no longer need the alternative presentation button.
10+
11+
* Source/cmake/OptionsMac.cmake:
12+
* Source/cmake/WebKitFeatures.cmake:
13+
* Source/cmake/tools/vsprops/FeatureDefines.props:
14+
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
15+
116
2017-12-20 Fujii Hironori <[email protected]>
217

318
[CMake][WTF] Lowercase ForwardingHeaders directory name of WTF

LayoutTests/ChangeLog

+26
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,29 @@
1+
2017-12-20 Daniel Bates <[email protected]>
2+
3+
Remove Alternative Presentation Button
4+
https://bugs.webkit.org/show_bug.cgi?id=180500
5+
<rdar://problem/35891047>
6+
7+
Reviewed by Simon Fraser.
8+
9+
We no longer need the alternative presentation button.
10+
11+
* TestExpectations:
12+
* accessibility/alternative-presentation-button-expected.txt: Removed.
13+
* accessibility/alternative-presentation-button-input-type-expected.txt: Removed.
14+
* accessibility/alternative-presentation-button-input-type.html: Removed.
15+
* accessibility/alternative-presentation-button.html: Removed.
16+
* fast/forms/alternative-presentation-button/replace-and-remove-expected.html: Removed.
17+
* fast/forms/alternative-presentation-button/replace-and-remove.html: Removed.
18+
* fast/forms/alternative-presentation-button/replaced-elements-expected.txt: Removed.
19+
* fast/forms/alternative-presentation-button/replaced-elements.html: Removed.
20+
* fast/forms/alternative-presentation-button/replacement-expected.txt: Removed.
21+
* fast/forms/alternative-presentation-button/replacement.html: Removed.
22+
* platform/gtk/TestExpectations:
23+
* platform/ios/TestExpectations:
24+
* platform/ios/fast/forms/alternative-presentation-button/replacement-expected.txt: Removed.
25+
* platform/mac/TestExpectations:
26+
127
2017-12-20 Chris Dumez <[email protected]>
228

329
Do not reuse resource for memory cache if selected service worker differs

LayoutTests/TestExpectations

-3
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@ fast/visual-viewport/tiled-drawing [ Skip ]
2222
swipe [ Skip ]
2323
fast/zooming/ios [ Skip ]
2424
fast/forms/ios [ Skip ]
25-
fast/forms/alternative-presentation-button [ Skip ]
26-
accessibility/alternative-presentation-button-input-type.html [ Skip ]
27-
accessibility/alternative-presentation-button.html [ Skip ]
2825
fast/viewport/ios [ Skip ]
2926
fast/visual-viewport/ios/ [ Skip ]
3027
fast/events/ios [ Skip ]

LayoutTests/accessibility/alternative-presentation-button-expected.txt

-14
This file was deleted.

LayoutTests/accessibility/alternative-presentation-button-input-type-expected.txt

-21
This file was deleted.

LayoutTests/accessibility/alternative-presentation-button-input-type.html

-37
This file was deleted.

LayoutTests/accessibility/alternative-presentation-button.html

-37
This file was deleted.

LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove-expected.html

-48
This file was deleted.

LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove.html

-69
This file was deleted.

LayoutTests/fast/forms/alternative-presentation-button/replaced-elements-expected.txt

-13
This file was deleted.

LayoutTests/fast/forms/alternative-presentation-button/replaced-elements.html

-59
This file was deleted.

0 commit comments

Comments
 (0)