Skip to content

Commit 216842a

Browse files
EWS bubble hover shows wrong timestamps
https://bugs.webkit.org/show_bug.cgi?id=137252 Reviewed by Alexey Proskuryakov. Add "Z" suffix to timestamps to make sure if it is handled as UTC time. * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON.get): * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._iso_time): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 08e294f commit 216842a

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

Tools/ChangeLog

+14
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
2014-10-06 Csaba Osztrogonác <[email protected]>
2+
3+
EWS bubble hover shows wrong timestamps
4+
https://bugs.webkit.org/show_bug.cgi?id=137252
5+
6+
Reviewed by Alexey Proskuryakov.
7+
8+
Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
9+
10+
* QueueStatusServer/handlers/queuestatusjson.py:
11+
(QueueStatusJSON.get):
12+
* QueueStatusServer/handlers/statusbubble.py:
13+
(StatusBubble._iso_time):
14+
115
2014-10-06 Mario Sanchez Prada <[email protected]>
216

317
Unreviewed, updated list of email addresses in contributors.json

Tools/QueueStatusServer/handlers/queuestatusjson.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,5 +116,5 @@ def get(self, queue_name):
116116
"queue": self._rows_for_work_items(queue),
117117
"bots": self._bots(queue),
118118
}
119-
dthandler = lambda obj: obj.isoformat() if isinstance(obj, datetime.datetime) or isinstance(obj, datetime.date) else None
119+
dthandler = lambda obj: obj.isoformat() + "Z" if isinstance(obj, datetime.datetime) or isinstance(obj, datetime.date) else None
120120
self.response.out.write(json.dumps(status, default=dthandler))

Tools/QueueStatusServer/handlers/statusbubble.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656

5757
class StatusBubble(webapp.RequestHandler):
5858
def _iso_time(self, time):
59-
return "[[" + time.isoformat() + "]]"
59+
return "[[" + time.isoformat() + "Z]]"
6060

6161
# queue_position includes items that are already active, so it's misleading.
6262
# For a queue that has 8 bots, being #9 in the queue actually means being #1.

0 commit comments

Comments
 (0)