Skip to content

Commit 6681581

Browse files
REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
https://bugs.webkit.org/show_bug.cgi?id=138323 Reviewed by Zalan Bujtas. * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@175488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 0bc83e5 commit 6681581

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

Tools/ChangeLog

+9
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
2014-11-03 Alexey Proskuryakov <[email protected]>
2+
3+
REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
4+
https://bugs.webkit.org/show_bug.cgi?id=138323
5+
6+
Reviewed by Zalan Bujtas.
7+
8+
* QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
9+
110
2014-11-03 Eva Balazsfalvi <[email protected]>
211

312
[ninja] Don't remove response files for verbose builds

Tools/QueueStatusServer/app.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
application: webkit-queues
2-
version: 174622 # SVN revision of last major change
2+
version: 175488 # SVN revision of last major change
33
runtime: python
44
api_version: 1
55

Tools/QueueStatusServer/templates/statusbubble.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@
5353
</style>
5454
<script>
5555
window.addEventListener("message", function(e) {
56-
if (e.data == 'containerMetrics') {
57-
e.source.postMessage({'width': bubbleContainer.offsetWidth, 'height': bubbleContainer.offsetHeight},
58-
e.origin);
56+
if (e.data === 'containerMetrics') {
57+
var clientRect = bubbleContainer.getBoundingClientRect();
58+
e.source.postMessage({'width': Math.ceil(clientRect.width), 'height': Math.ceil(clientRect.height)}, e.origin);
5959
} else
6060
console.log("Unknown postMessage: " + e.data);
6161
}, false);

0 commit comments

Comments
 (0)