bisect-builds:add a README to the archive.

https://bugs.webkit.org/show_bug.cgi?id=177376

Reviewed by Alexey Proskuryakov & Jon Davis.

* BuildSlaveSupport/built-product-archive:
(addFilesToArchive): refactor function (was previously addLauncherToArchive)
(createZip): Teach function to add the README
(addLauncherToArchive): Deleted. (refactored to addFilesToArchive)
* BuildSlaveSupport/run-webkit-archive: Deleted. (Moved to WebKitArchiveSupport)
* WebKitArchiveSupport: Added.
* WebKitArchiveSupport/README: Added. README which will be packaged up with the archive.
* WebKitArchiveSupport/run-webkit-archive: Added. (Moved from BuildSlaveSupport)



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@222558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Tools/BuildSlaveSupport/built-product-archive

@@ -36,7 +36,8 @@ _configurationBuildDirectory = None
 _topLevelBuildDirectory = None
 _hostBuildDirectory = None
 
-PATH_TO_LAUNCHER = './Tools/BuildSlaveSupport/run-webkit-archive'
+PATH_TO_LAUNCHER = './Tools/WebKitArchiveSupport/run-webkit-archive'
+PATH_TO_README = './Tools/WebKitArchiveSupport/README'
 
 def main():
     parser = optparse.OptionParser("usage: %prog [options] [action]")
@@ -137,8 +138,8 @@ def createZipManually(directoryToZip, archiveFile):
 
     archiveZip.close()
 
-def addLauncherToArchive(archiveFile):
-    command = ['/usr/bin/zip', '-j', archiveFile, PATH_TO_LAUNCHER]
+def addFilesToArchive(archiveFile, pathToLauncher, pathToReadme):
+    command = ['/usr/bin/zip', '-j', archiveFile, pathToLauncher, pathToReadme]
     return subprocess.call(command)
 
 def createZip(directoryToZip, configuration, embedParentDirectoryNameOnDarwin=False, minify=False):
@@ -158,7 +159,7 @@ def createZip(directoryToZip, configuration, embedParentDirectoryNameOnDarwin=Fa
         if embedParentDirectoryNameOnDarwin:
             command += ['--keepParent']
         command += [directoryToZip, archiveFile]
-        return subprocess.call(command) or addLauncherToArchive(archiveFile)
+        return subprocess.call(command) or addFilesToArchive(archiveFile, PATH_TO_LAUNCHER, PATH_TO_README) 
     elif sys.platform == 'cygwin':
         return subprocess.call(["zip", "-r", archiveFile, "bin32"], cwd=directoryToZip)
     elif sys.platform == 'win32':

Tools/ChangeLog

@@ -1,3 +1,19 @@
+2017-09-27  Lucas Forschler  <[email protected]>
+
+        bisect-builds:add a README to the archive.
+        https://bugs.webkit.org/show_bug.cgi?id=177376
+
+        Reviewed by Alexey Proskuryakov & Jon Davis.
+
+        * BuildSlaveSupport/built-product-archive:
+        (addFilesToArchive): refactor function (was previously addLauncherToArchive)
+        (createZip): Teach function to add the README
+        (addLauncherToArchive): Deleted. (refactored to addFilesToArchive)
+        * BuildSlaveSupport/run-webkit-archive: Deleted. (Moved to WebKitArchiveSupport)
+        * WebKitArchiveSupport: Added.
+        * WebKitArchiveSupport/README: Added. README which will be packaged up with the archive.
+        * WebKitArchiveSupport/run-webkit-archive: Added. (Moved from BuildSlaveSupport)
+
 2017-09-26  Tim Horton  <[email protected]>
 
         Mac CMake bot should provide verbose build output

Tools/WebKitArchiveSupport/README

@@ -0,0 +1,4 @@
+WebKit nightly archives are not code signed. Please open run-webkit-archive
+using the context menu in Finder.
+
+See https://support.apple.com/kb/PH25088 for more details.