Skip to content

Commit 947d23c

Browse files
Create bindings for WebGL2's versions of compressedTexImage2D.
https://bugs.webkit.org/show_bug.cgi?id=177481 Reviewed by Žan Doberšek. No new tests: not much point in adding tests now; this method doesn't do anything anyway. * html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::compressedTexImage2D): * html/canvas/WebGL2RenderingContext.h: * html/canvas/WebGL2RenderingContext.idl: * html/canvas/WebGLRenderingContext.idl: * html/canvas/WebGLRenderingContextBase.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@222974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent a8748f3 commit 947d23c

6 files changed

+42
-2
lines changed

Source/WebCore/ChangeLog

+17
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
1+
2017-10-06 Ms2ger <[email protected]>
2+
3+
Create bindings for WebGL2's versions of compressedTexImage2D.
4+
https://bugs.webkit.org/show_bug.cgi?id=177481
5+
6+
Reviewed by Žan Doberšek.
7+
8+
No new tests: not much point in adding tests now; this method doesn't
9+
do anything anyway.
10+
11+
* html/canvas/WebGL2RenderingContext.cpp:
12+
(WebCore::WebGL2RenderingContext::compressedTexImage2D):
13+
* html/canvas/WebGL2RenderingContext.h:
14+
* html/canvas/WebGL2RenderingContext.idl:
15+
* html/canvas/WebGLRenderingContext.idl:
16+
* html/canvas/WebGLRenderingContextBase.idl:
17+
118
2017-10-06 Enrique Ocaña González <[email protected]>
219

320
[GStreamer][MSE] Likely race condition causes WTF::Deque to crash on debug

Source/WebCore/html/canvas/WebGL2RenderingContext.cpp

+8
Original file line numberDiff line numberDiff line change
@@ -495,6 +495,14 @@ void WebGL2RenderingContext::copyTexSubImage3D(GC3Denum, GC3Dint, GC3Dint, GC3Di
495495
{
496496
}
497497

498+
void WebGL2RenderingContext::compressedTexImage2D(GC3Denum, GC3Dint, GC3Denum, GC3Dsizei, GC3Dsizei, GC3Dint, GC3Dsizei, GC3Dint64)
499+
{
500+
}
501+
502+
void WebGL2RenderingContext::compressedTexImage2D(GC3Denum, GC3Dint, GC3Denum, GC3Dsizei, GC3Dsizei, GC3Dint, ArrayBufferView&, GC3Duint, GC3Duint)
503+
{
504+
}
505+
498506
void WebGL2RenderingContext::compressedTexImage3D(GC3Denum, GC3Dint, GC3Denum, GC3Dsizei, GC3Dsizei, GC3Dsizei, GC3Dint, GC3Dsizei, GC3Dint64)
499507
{
500508
}

Source/WebCore/html/canvas/WebGL2RenderingContext.h

+3
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ class WebGL2RenderingContext final : public WebGLRenderingContextBase {
7272
void texSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Denum format, GC3Denum type, TexImageSource&&);
7373

7474
void copyTexSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Dint x, GC3Dint y, GC3Dsizei width, GC3Dsizei height);
75+
76+
void compressedTexImage2D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dint border, GC3Dsizei imageSize, GC3Dint64 offset);
77+
void compressedTexImage2D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dint border, ArrayBufferView& data, GC3Duint, GC3Duint);
7578
void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, GC3Dsizei imageSize, GC3Dint64 offset);
7679
void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, ArrayBufferView& srcData, GC3Duint srcOffset, GC3Duint srcLengthOverride);
7780
void compressedTexSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Denum format, GC3Dsizei imageSize, RefPtr<ArrayBufferView>&& data);

Source/WebCore/html/canvas/WebGL2RenderingContext.idl

+3
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,9 @@ typedef (ImageData or HTMLImageElement or HTMLCanvasElement or HTMLVideoElement)
370370

371371
void copyTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLint x, GLint y, GLsizei width, GLsizei height);
372372

373+
void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLint border, GLsizei imageSize, GLintptr offset);
374+
void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLint border, ArrayBufferView srcData, optional GLuint srcOffset = 0, optional GLuint srcLengthOverride = 0);
375+
373376
void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, GLsizei imageSize, GLintptr offset);
374377
void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, ArrayBufferView srcData, optional GLuint srcOffset = 0, optional GLuint srcLengthOverride = 0);
375378
void compressedTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth, GLenum format, GLsizei imageSize, ArrayBufferView? data);

Source/WebCore/html/canvas/WebGLRenderingContext.idl

+7
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2424
*/
2525

26+
typedef unsigned long GLenum;
27+
typedef long GLint;
28+
typedef long GLsizei;
29+
2630
[
2731
Conditional=WEBGL,
2832
JSCustomMarkFunction,
@@ -31,6 +35,9 @@
3135
ExportMacro=WEBCORE_EXPORT,
3236
CallTracingCallback=recordCanvasAction,
3337
] interface WebGLRenderingContext {
38+
// This method is placed outside of WebGLRenderingContextBase to avoid
39+
// conficts with overloads in WebGL2RenderingContext.
40+
void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLint border, ArrayBufferView data);
3441
};
3542

3643
WebGLRenderingContext implements WebGLRenderingContextBase;

Source/WebCore/html/canvas/WebGLRenderingContextBase.idl

+4-2
Original file line numberDiff line numberDiff line change
@@ -507,8 +507,10 @@ typedef (ImageData or HTMLImageElement or HTMLCanvasElement) TexImageSource;
507507
void colorMask(GLboolean red, GLboolean green, GLboolean blue, GLboolean alpha);
508508
void compileShader(WebGLShader? shader);
509509

510-
void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat,
511-
GLsizei width, GLsizei height, GLint border, ArrayBufferView data);
510+
// compressedTexImage2D is split between WebGLRenderingContext and
511+
// WebGL2RenderingContext because the ArrayBufferView overloads are
512+
// indistinguishable.
513+
512514
void compressedTexSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
513515
GLsizei width, GLsizei height, GLenum format, ArrayBufferView data);
514516

0 commit comments

Comments
 (0)