Skip to content

Commit 955cb3f

Browse files
author
[email protected]
committed
Add a WebAuthentication runtime feature flag
https://bugs.webkit.org/show_bug.cgi?id=181220 <rdar://problem/36055305> Reviewed by Brent Fulgham. Source/WebCore: This patch basically renames the CredentialManagement runtime feature flag into WebAuthentication runtime feature flag. No tests. * Modules/credentialmanagement/BasicCredential.idl: * Modules/credentialmanagement/CredentialsContainer.idl: * Modules/credentialmanagement/NavigatorCredentials.idl: * Modules/webauthn/PublicKeyCredential.idl: * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebAuthenticationEnabled): (WebCore::RuntimeEnabledFeatures::webAuthenticationEnabled const): (WebCore::RuntimeEnabledFeatures::setCredentialManagementEnabled): Deleted. (WebCore::RuntimeEnabledFeatures::credentialManagementEnabled const): Deleted. Source/WebKit: Renames the CredentialManagement runtime feature flag into WebAuthentication. * Shared/WebPreferences.yaml: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetWebAuthenticationEnabled): (WKPreferencesGetWebAuthenticationEnabled): (WKPreferencesSetCredentialManagementEnabled): Deleted. (WKPreferencesGetCredentialManagementEnabled): Deleted. * UIProcess/API/C/WKPreferencesRefPrivate.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Source/WebKitLegacy/mac: Renames the CredentialManagement runtime feature flag into WebAuthentication. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences webAuthenticationEnabled]): (-[WebPreferences setWebAuthenticationEnabled:]): (-[WebPreferences credentialManagementEnabled]): Deleted. (-[WebPreferences setCredentialManagementEnabled:]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Tools: Renames the CredentialManagement runtime feature flag into WebAuthentication. * DumpRenderTree/TestOptions.h: * DumpRenderTree/TestOptions.mm: (TestOptions::TestOptions): * DumpRenderTree/mac/DumpRenderTree.mm: (enableExperimentalFeatures): (setWebPreferencesForTestOptions): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestOptions.h: (WTR::TestOptions::hasSameInitializationOptions const): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@226341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 72ce720 commit 955cb3f

22 files changed

+124
-36
lines changed

‎Source/WebCore/ChangeLog

+23
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,26 @@
1+
2018-01-02 Jiewen Tan <[email protected]>
2+
3+
Add a WebAuthentication runtime feature flag
4+
https://bugs.webkit.org/show_bug.cgi?id=181220
5+
<rdar://problem/36055305>
6+
7+
Reviewed by Brent Fulgham.
8+
9+
This patch basically renames the CredentialManagement runtime feature flag into
10+
WebAuthentication runtime feature flag.
11+
12+
No tests.
13+
14+
* Modules/credentialmanagement/BasicCredential.idl:
15+
* Modules/credentialmanagement/CredentialsContainer.idl:
16+
* Modules/credentialmanagement/NavigatorCredentials.idl:
17+
* Modules/webauthn/PublicKeyCredential.idl:
18+
* page/RuntimeEnabledFeatures.h:
19+
(WebCore::RuntimeEnabledFeatures::setWebAuthenticationEnabled):
20+
(WebCore::RuntimeEnabledFeatures::webAuthenticationEnabled const):
21+
(WebCore::RuntimeEnabledFeatures::setCredentialManagementEnabled): Deleted.
22+
(WebCore::RuntimeEnabledFeatures::credentialManagementEnabled const): Deleted.
23+
124
2018-01-02 Wenson Hsieh <[email protected]>
225

326
[Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls

‎Source/WebCore/Modules/credentialmanagement/BasicCredential.idl

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
[
2727
InterfaceName=Credential,
28-
EnabledAtRuntime=CredentialManagement,
28+
EnabledAtRuntime=WebAuthentication,
2929
Exposed=Window,
3030
SecureContext
3131
] interface BasicCredential {

‎Source/WebCore/Modules/credentialmanagement/CredentialsContainer.idl

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*/
2626

2727
[
28-
EnabledAtRuntime=CredentialManagement,
28+
EnabledAtRuntime=WebAuthentication,
2929
Exposed=Window,
3030
ImplementationLacksVTable,
3131
SecureContext,

‎Source/WebCore/Modules/credentialmanagement/NavigatorCredentials.idl

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*/
2626

2727
[
28-
EnabledAtRuntime=CredentialManagement,
28+
EnabledAtRuntime=WebAuthentication,
2929
] partial interface Navigator {
3030
[SecureContext, SameObject] readonly attribute CredentialsContainer credentials;
3131
};

‎Source/WebCore/Modules/webauthn/PublicKeyCredential.idl

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
*/
2525

2626
[
27-
EnabledAtRuntime=CredentialManagement,
27+
EnabledAtRuntime=WebAuthentication,
2828
Exposed=Window,
2929
SecureContext,
3030
] interface PublicKeyCredential {

‎Source/WebCore/page/RuntimeEnabledFeatures.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ class RuntimeEnabledFeatures {
9090
void setModernMediaControlsEnabled(bool areEnabled) { m_areModernMediaControlsEnabled = areEnabled; }
9191
bool modernMediaControlsEnabled() const { return m_areModernMediaControlsEnabled; }
9292

93-
void setCredentialManagementEnabled(bool isEnabled) { m_isCredentialManagementEnabled = isEnabled; }
94-
bool credentialManagementEnabled() const { return m_isCredentialManagementEnabled; }
93+
void setWebAuthenticationEnabled(bool isEnabled) { m_isWebAuthenticationEnabled = isEnabled; }
94+
bool webAuthenticationEnabled() const { return m_isWebAuthenticationEnabled; }
9595

9696
void setIsSecureContextAttributeEnabled(bool isEnabled) { m_isSecureContextAttributeEnabled = isEnabled; }
9797
bool isSecureContextAttributeEnabled() const { return m_isSecureContextAttributeEnabled; }
@@ -248,7 +248,7 @@ class RuntimeEnabledFeatures {
248248
bool m_isResourceTimingEnabled { false };
249249
bool m_isUserTimingEnabled { false };
250250
bool m_isInteractiveFormValidationEnabled { false };
251-
bool m_isCredentialManagementEnabled { false };
251+
bool m_isWebAuthenticationEnabled { false };
252252
bool m_isSecureContextAttributeEnabled { false };
253253

254254
bool m_isDisplayContentsEnabled { true };

‎Source/WebKit/ChangeLog

+20
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,23 @@
1+
2018-01-02 Jiewen Tan <[email protected]>
2+
3+
Add a WebAuthentication runtime feature flag
4+
https://bugs.webkit.org/show_bug.cgi?id=181220
5+
<rdar://problem/36055305>
6+
7+
Reviewed by Brent Fulgham.
8+
9+
Renames the CredentialManagement runtime feature flag into WebAuthentication.
10+
11+
* Shared/WebPreferences.yaml:
12+
* UIProcess/API/C/WKPreferences.cpp:
13+
(WKPreferencesSetWebAuthenticationEnabled):
14+
(WKPreferencesGetWebAuthenticationEnabled):
15+
(WKPreferencesSetCredentialManagementEnabled): Deleted.
16+
(WKPreferencesGetCredentialManagementEnabled): Deleted.
17+
* UIProcess/API/C/WKPreferencesRefPrivate.h:
18+
* WebProcess/WebPage/WebPage.cpp:
19+
(WebKit::WebPage::updatePreferences):
20+
121
2018-01-02 Michael Catanzaro <[email protected]>
222

323
REGRESSION(r226327): [GTK] Plugin process is broken

‎Source/WebKit/Shared/WebPreferences.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -703,11 +703,11 @@ InputEventsEnabled:
703703
humanReadableDescription: "Enable InputEvents support"
704704
webcoreBinding: RuntimeEnabledFeatures
705705

706-
CredentialManagementEnabled:
706+
WebAuthenticationEnabled:
707707
type: bool
708708
defaultValue: false
709-
humanReadableName: "Credential Management"
710-
humanReadableDescription: "Enable Credential Management support"
709+
humanReadableName: "Web Authentication"
710+
humanReadableDescription: "Enable Web Authentication support"
711711
webcoreBinding: RuntimeEnabledFeatures
712712

713713
ModernMediaControlsEnabled:

‎Source/WebKit/UIProcess/API/C/WKPreferences.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -870,14 +870,14 @@ bool WKPreferencesGetModernMediaControlsEnabled(WKPreferencesRef preferencesRef)
870870
return toImpl(preferencesRef)->modernMediaControlsEnabled();
871871
}
872872

873-
void WKPreferencesSetCredentialManagementEnabled(WKPreferencesRef preferencesRef, bool flag)
873+
void WKPreferencesSetWebAuthenticationEnabled(WKPreferencesRef preferencesRef, bool flag)
874874
{
875-
toImpl(preferencesRef)->setCredentialManagementEnabled(flag);
875+
toImpl(preferencesRef)->setWebAuthenticationEnabled(flag);
876876
}
877877

878-
bool WKPreferencesGetCredentialManagementEnabled(WKPreferencesRef preferencesRef)
878+
bool WKPreferencesGetWebAuthenticationEnabled(WKPreferencesRef preferencesRef)
879879
{
880-
return toImpl(preferencesRef)->credentialManagementEnabled();
880+
return toImpl(preferencesRef)->webAuthenticationEnabled();
881881
}
882882

883883
void WKPreferencesSetInvisibleMediaAutoplayPermitted(WKPreferencesRef preferencesRef, bool flag)

‎Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -514,8 +514,8 @@ WK_EXPORT void WKPreferencesSetMediaPreloadingEnabled(WKPreferencesRef, bool fla
514514
WK_EXPORT bool WKPreferencesGetMediaPreloadingEnabled(WKPreferencesRef);
515515

516516
// Defaults to false
517-
WK_EXPORT void WKPreferencesSetCredentialManagementEnabled(WKPreferencesRef, bool flag);
518-
WK_EXPORT bool WKPreferencesGetCredentialManagementEnabled(WKPreferencesRef);
517+
WK_EXPORT void WKPreferencesSetWebAuthenticationEnabled(WKPreferencesRef, bool flag);
518+
WK_EXPORT bool WKPreferencesGetWebAuthenticationEnabled(WKPreferencesRef);
519519

520520
// Defaults to true.
521521
WK_EXPORT void WKPreferencesSetInvisibleMediaAutoplayPermitted(WKPreferencesRef, bool flag);

‎Source/WebKit/WebProcess/WebPage/WebPage.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -3070,6 +3070,8 @@ void WebPage::updatePreferences(const WebPreferencesStore& store)
30703070
RuntimeEnabledFeatures::sharedFeatures().setWebRTCLegacyAPIEnabled(!store.getBoolValueForKey(WebPreferencesKey::webRTCLegacyAPIDisabledKey()));
30713071
#endif
30723072

3073+
RuntimeEnabledFeatures::sharedFeatures().setWebAuthenticationEnabled(store.getBoolValueForKey(WebPreferencesKey::webAuthenticationEnabledKey()));
3074+
30733075
DatabaseManager::singleton().setIsAvailable(store.getBoolValueForKey(WebPreferencesKey::databasesEnabledKey()));
30743076

30753077
m_tabToLinks = store.getBoolValueForKey(WebPreferencesKey::tabsToLinksKey());

‎Source/WebKitLegacy/mac/ChangeLog

+21
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,24 @@
1+
2018-01-02 Jiewen Tan <[email protected]>
2+
3+
Add a WebAuthentication runtime feature flag
4+
https://bugs.webkit.org/show_bug.cgi?id=181220
5+
<rdar://problem/36055305>
6+
7+
Reviewed by Brent Fulgham.
8+
9+
Renames the CredentialManagement runtime feature flag into WebAuthentication.
10+
11+
* WebView/WebPreferenceKeysPrivate.h:
12+
* WebView/WebPreferences.mm:
13+
(+[WebPreferences initialize]):
14+
(-[WebPreferences webAuthenticationEnabled]):
15+
(-[WebPreferences setWebAuthenticationEnabled:]):
16+
(-[WebPreferences credentialManagementEnabled]): Deleted.
17+
(-[WebPreferences setCredentialManagementEnabled:]): Deleted.
18+
* WebView/WebPreferencesPrivate.h:
19+
* WebView/WebView.mm:
20+
(-[WebView _preferencesChanged:]):
21+
122
2017-12-22 Jeff Miller <[email protected]>
223

324
Update user-visible copyright strings to include 2018

‎Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@
189189
#define WebKitWebRTCLegacyAPIEnabledPreferenceKey @"WebKitWebRTCLegacyAPIEnabled"
190190
#define WebKitLinkPreloadEnabledPreferenceKey @"WebKitLinkPreloadEnabled"
191191
#define WebKitMediaPreloadingEnabledPreferenceKey @"WebKitMediaPreloadingEnabled"
192-
#define WebKitCredentialManagementEnabledPreferenceKey @"WebKitCredentialManagementEnabled"
192+
#define WebKitWebAuthenticationEnabledPreferenceKey @"WebKitWebAuthenticationEnabled"
193193
#define WebKitMediaUserGestureInheritsFromDocument @"WebKitMediaUserGestureInheritsFromDocument"
194194
#define WebKitIsSecureContextAttributeEnabledPreferenceKey @"WebKitIsSecureContextAttributeEnabled"
195195
#define WebKitViewportFitEnabledPreferenceKey @"WebKitViewportFitEnabled"

‎Source/WebKitLegacy/mac/WebView/WebPreferences.mm

+5-5
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ + (void)initialize
666666
@YES, WebKitDisplayContentsEnabledPreferenceKey,
667667
@NO, WebKitUserTimingEnabledPreferenceKey,
668668
@NO, WebKitResourceTimingEnabledPreferenceKey,
669-
@NO, WebKitCredentialManagementEnabledPreferenceKey,
669+
@NO, WebKitWebAuthenticationEnabledPreferenceKey,
670670
@NO, WebKitMediaUserGestureInheritsFromDocument,
671671
@NO, WebKitIsSecureContextAttributeEnabledPreferenceKey,
672672
#if PLATFORM(IOS)
@@ -3155,14 +3155,14 @@ - (void)setResourceTimingEnabled:(BOOL)flag
31553155
[self _setBoolValue:flag forKey:WebKitResourceTimingEnabledPreferenceKey];
31563156
}
31573157

3158-
- (BOOL)credentialManagementEnabled
3158+
- (BOOL)webAuthenticationEnabled
31593159
{
3160-
return [self _boolValueForKey:WebKitCredentialManagementEnabledPreferenceKey];
3160+
return [self _boolValueForKey:WebKitWebAuthenticationEnabledPreferenceKey];
31613161
}
31623162

3163-
- (void)setCredentialManagementEnabled:(BOOL)flag
3163+
- (void)setWebAuthenticationEnabled:(BOOL)flag
31643164
{
3165-
[self _setBoolValue:flag forKey:WebKitCredentialManagementEnabledPreferenceKey];
3165+
[self _setBoolValue:flag forKey:WebKitWebAuthenticationEnabledPreferenceKey];
31663166
}
31673167

31683168
- (BOOL)mediaUserGestureInheritsFromDocument

‎Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -567,8 +567,8 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification;
567567
- (void)setModernMediaControlsEnabled:(BOOL)flag;
568568
- (BOOL)modernMediaControlsEnabled;
569569

570-
- (void)setCredentialManagementEnabled:(BOOL)flag;
571-
- (BOOL)credentialManagementEnabled;
570+
- (void)setWebAuthenticationEnabled:(BOOL)flag;
571+
- (BOOL)webAuthenticationEnabled;
572572

573573
- (void)setIsSecureContextAttributeEnabled:(BOOL)flag;
574574
- (BOOL)isSecureContextAttributeEnabled;
@@ -587,7 +587,7 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification;
587587
@property (nonatomic) BOOL userTimingEnabled;
588588
@property (nonatomic) BOOL resourceTimingEnabled;
589589
@property (nonatomic) BOOL linkPreloadEnabled;
590-
@property (nonatomic) BOOL credentialManagementEnabled;
590+
@property (nonatomic) BOOL webAuthenticationEnabled;
591591
@property (nonatomic) BOOL mediaUserGestureInheritsFromDocument;
592592
@property (nonatomic) BOOL isSecureContextAttributeEnabled;
593593
@property (nonatomic) BOOL legacyEncryptedMediaAPIEnabled;

‎Source/WebKitLegacy/mac/WebView/WebView.mm

+1-1
Original file line numberDiff line numberDiff line change
@@ -3041,7 +3041,7 @@ - (void)_preferencesChanged:(WebPreferences *)preferences
30413041
RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(preferences.resourceTimingEnabled);
30423042
RuntimeEnabledFeatures::sharedFeatures().setLinkPreloadEnabled(preferences.linkPreloadEnabled);
30433043
RuntimeEnabledFeatures::sharedFeatures().setMediaPreloadingEnabled(preferences.mediaPreloadingEnabled);
3044-
RuntimeEnabledFeatures::sharedFeatures().setCredentialManagementEnabled(preferences.credentialManagementEnabled);
3044+
RuntimeEnabledFeatures::sharedFeatures().setWebAuthenticationEnabled(preferences.webAuthenticationEnabled);
30453045
RuntimeEnabledFeatures::sharedFeatures().setIsSecureContextAttributeEnabled(preferences.isSecureContextAttributeEnabled);
30463046
RuntimeEnabledFeatures::sharedFeatures().setDirectoryUploadEnabled([preferences directoryUploadEnabled]);
30473047
RuntimeEnabledFeatures::sharedFeatures().setMenuItemElementEnabled([preferences menuItemElementEnabled]);

‎Tools/ChangeLog

+22
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,25 @@
1+
2018-01-02 Jiewen Tan <[email protected]>
2+
3+
Add a WebAuthentication runtime feature flag
4+
https://bugs.webkit.org/show_bug.cgi?id=181220
5+
<rdar://problem/36055305>
6+
7+
Reviewed by Brent Fulgham.
8+
9+
Renames the CredentialManagement runtime feature flag into WebAuthentication.
10+
11+
* DumpRenderTree/TestOptions.h:
12+
* DumpRenderTree/TestOptions.mm:
13+
(TestOptions::TestOptions):
14+
* DumpRenderTree/mac/DumpRenderTree.mm:
15+
(enableExperimentalFeatures):
16+
(setWebPreferencesForTestOptions):
17+
* WebKitTestRunner/TestController.cpp:
18+
(WTR::TestController::resetPreferencesToConsistentValues):
19+
(WTR::updateTestOptionsFromTestHeader):
20+
* WebKitTestRunner/TestOptions.h:
21+
(WTR::TestOptions::hasSameInitializationOptions const):
22+
123
2018-01-02 Wenson Hsieh <[email protected]>
224

325
[Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls

‎Tools/DumpRenderTree/TestOptions.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ struct TestOptions {
3535
bool enableMenuItemElement { false };
3636
bool enableModernMediaControls { true };
3737
bool enablePointerLock { false };
38-
bool enableCredentialManagement { true };
38+
bool enableWebAuthentication { true };
3939
bool enableDragDestinationActionLoad { false };
4040
bool layerBackedWebView { false };
4141
bool enableIsSecureContextAttribute { true };

‎Tools/DumpRenderTree/TestOptions.mm

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ static bool parseBooleanTestHeaderValue(const std::string& value)
9090
this->enableModernMediaControls = parseBooleanTestHeaderValue(value);
9191
else if (key == "enablePointerLock")
9292
this->enablePointerLock = parseBooleanTestHeaderValue(value);
93-
else if (key == "enableCredentialManagement")
94-
this->enableCredentialManagement = parseBooleanTestHeaderValue(value);
93+
else if (key == "enableWebAuthentication")
94+
this->enableWebAuthentication = parseBooleanTestHeaderValue(value);
9595
else if (key == "enableDragDestinationActionLoad")
9696
this->enableDragDestinationActionLoad = parseBooleanTestHeaderValue(value);
9797
else if (key == "layerBackedWebView")

‎Tools/DumpRenderTree/mac/DumpRenderTree.mm

+2-2
Original file line numberDiff line numberDiff line change
@@ -850,7 +850,7 @@ static void enableExperimentalFeatures(WebPreferences* preferences)
850850
[preferences setWebGPUEnabled:YES];
851851
// FIXME: AsyncFrameScrollingEnabled
852852
[preferences setWebRTCLegacyAPIEnabled:YES];
853-
[preferences setCredentialManagementEnabled:YES];
853+
[preferences setWebAuthenticationEnabled:NO];
854854
[preferences setCacheAPIEnabled:NO];
855855
[preferences setReadableByteStreamAPIEnabled:YES];
856856
[preferences setWritableStreamAPIEnabled:YES];
@@ -989,7 +989,7 @@ static void setWebPreferencesForTestOptions(const TestOptions& options)
989989
preferences.intersectionObserverEnabled = options.enableIntersectionObserver;
990990
preferences.menuItemElementEnabled = options.enableMenuItemElement;
991991
preferences.modernMediaControlsEnabled = options.enableModernMediaControls;
992-
preferences.credentialManagementEnabled = options.enableCredentialManagement;
992+
preferences.webAuthenticationEnabled = options.enableWebAuthentication;
993993
preferences.isSecureContextAttributeEnabled = options.enableIsSecureContextAttribute;
994994
preferences.inspectorAdditionsEnabled = options.enableInspectorAdditions;
995995
}

‎Tools/WebKitTestRunner/TestController.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ void TestController::resetPreferencesToConsistentValues(const TestOptions& optio
691691
WKPreferencesSetIntersectionObserverEnabled(preferences, options.enableIntersectionObserver);
692692
WKPreferencesSetMenuItemElementEnabled(preferences, options.enableMenuItemElement);
693693
WKPreferencesSetModernMediaControlsEnabled(preferences, options.enableModernMediaControls);
694-
WKPreferencesSetCredentialManagementEnabled(preferences, options.enableCredentialManagement);
694+
WKPreferencesSetWebAuthenticationEnabled(preferences, options.enableWebAuthentication);
695695
WKPreferencesSetIsSecureContextAttributeEnabled(preferences, options.enableIsSecureContextAttribute);
696696

697697
static WKStringRef defaultTextEncoding = WKStringCreateWithUTF8CString("ISO-8859-1");
@@ -1059,8 +1059,8 @@ static void updateTestOptionsFromTestHeader(TestOptions& testOptions, const std:
10591059
testOptions.enableModernMediaControls = parseBooleanTestHeaderValue(value);
10601060
if (key == "enablePointerLock")
10611061
testOptions.enablePointerLock = parseBooleanTestHeaderValue(value);
1062-
if (key == "enableCredentialManagement")
1063-
testOptions.enableCredentialManagement = parseBooleanTestHeaderValue(value);
1062+
if (key == "enableWebAuthentication")
1063+
testOptions.enableWebAuthentication = parseBooleanTestHeaderValue(value);
10641064
if (key == "enableIsSecureContextAttribute")
10651065
testOptions.enableIsSecureContextAttribute = parseBooleanTestHeaderValue(value);
10661066
if (key == "enableInspectorAdditions")

‎Tools/WebKitTestRunner/TestOptions.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ struct TestOptions {
4949
bool enableMenuItemElement { false };
5050
bool enableModernMediaControls { true };
5151
bool enablePointerLock { false };
52-
bool enableCredentialManagement { true };
52+
bool enableWebAuthentication { true };
5353
bool enableIsSecureContextAttribute { true };
5454
bool enableInspectorAdditions { false };
5555
bool shouldShowTouches { false };
@@ -78,7 +78,7 @@ struct TestOptions {
7878
|| enableMenuItemElement != options.enableMenuItemElement
7979
|| enableModernMediaControls != options.enableModernMediaControls
8080
|| enablePointerLock != options.enablePointerLock
81-
|| enableCredentialManagement != options.enableCredentialManagement
81+
|| enableWebAuthentication != options.enableWebAuthentication
8282
|| enableIsSecureContextAttribute != options.enableIsSecureContextAttribute
8383
|| enableInspectorAdditions != options.enableInspectorAdditions
8484
|| dumpJSConsoleLogInStdErr != options.dumpJSConsoleLogInStdErr

0 commit comments

Comments
 (0)