Web Inspector: Should not try to autocomplete subsections of a string

https://bugs.webkit.org/show_bug.cgi?id=181461
<rdar://problem/36369421>

Patch by Joseph Pecoraro <[email protected]> on 2018-01-10
Reviewed by Brian Burg.

* UserInterface/Controllers/CodeMirrorCompletionController.js:
(WI.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
Disable autocompletion within strings.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@226728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Source/WebInspectorUI/ChangeLog

@@ -1,3 +1,15 @@
+2018-01-10  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: Should not try to autocomplete subsections of a string
+        https://bugs.webkit.org/show_bug.cgi?id=181461
+        <rdar://problem/36369421>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Controllers/CodeMirrorCompletionController.js:
+        (WI.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
+        Disable autocompletion within strings.
+
 2018-01-09  Joseph Pecoraro  <[email protected]>
 
         REGRESSION(r201855): Web Inspector: Should see "length" autocompletion suggestion on a string literal

Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js

@@ -475,8 +475,8 @@ WI.CodeMirrorCompletionController = class CodeMirrorCompletionController extends
         var cursor = this._codeMirror.getCursor();
         var token = this._codeMirror.getTokenAt(cursor);
 
-        // Don't try to complete inside comments.
-        if (token.type && /\bcomment\b/.test(token.type)) {
+        // Don't try to complete inside comments or strings.
+        if (token.type && /\b(comment|string)\b/.test(token.type)) {
             this.hideCompletions();
             return;
         }