Skip to content

Commit 9b6c946

Browse files
[WebRTC] Add support for runtime PeeConnection setting, required after r209757
https://bugs.webkit.org/show_bug.cgi?id=166346 Patch by Alejandro G. Castro <[email protected]> on 2016-12-22 Reviewed by Carlos Garcia Campos. Source/WebKit2: After that commit we have to enable the peerConnection runtime flag if we want webrtc to work. We are not adding a new API for the moment to control the peerConnection feature. * UIProcess/API/gtk/WebKitSettings.cpp: (webkit_settings_set_enable_media_stream): Use the mediaStream setting to control the peerConnection Tools: Enable WebRTC by default to simplify testing. * MiniBrowser/gtk/main.c: (main): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@210096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 04b6985 commit 9b6c946

File tree

4 files changed

+29
-0
lines changed

4 files changed

+29
-0
lines changed

Source/WebKit2/ChangeLog

+15
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
2016-12-22 Alejandro G. Castro <[email protected]>
2+
3+
[WebRTC] Add support for runtime PeeConnection setting, required after r209757
4+
https://bugs.webkit.org/show_bug.cgi?id=166346
5+
6+
Reviewed by Carlos Garcia Campos.
7+
8+
After that commit we have to enable the peerConnection runtime
9+
flag if we want webrtc to work. We are not adding a new API for
10+
the moment to control the peerConnection feature.
11+
12+
* UIProcess/API/gtk/WebKitSettings.cpp:
13+
(webkit_settings_set_enable_media_stream): Use the mediaStream
14+
setting to control the peerConnection
15+
116
2016-12-21 Brent Fulgham <[email protected]>
217

318
[Mac][WK2] Stop using file* rules in WebProcess sandbox profiles

Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -2973,6 +2973,7 @@ void webkit_settings_set_enable_media_stream(WebKitSettings* settings, gboolean
29732973
return;
29742974

29752975
priv->preferences->setMediaStreamEnabled(enabled);
2976+
priv->preferences->setPeerConnectionEnabled(enabled);
29762977
g_object_notify(G_OBJECT(settings), "enable-media-stream");
29772978
}
29782979

Tools/ChangeLog

+12
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
2016-12-22 Alejandro G. Castro <[email protected]>
2+
3+
[WebRTC] Add support for runtime PeeConnection setting, required after r209757
4+
https://bugs.webkit.org/show_bug.cgi?id=166346
5+
6+
Reviewed by Carlos Garcia Campos.
7+
8+
Enable WebRTC by default to simplify testing.
9+
10+
* MiniBrowser/gtk/main.c:
11+
(main):
12+
113
2016-12-21 Alexey Proskuryakov <[email protected]>
214

315
REGRESSION: API test failure: WKWebView.LocalStorageClear

Tools/MiniBrowser/gtk/main.c

+1
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,7 @@ int main(int argc, char *argv[])
269269
WebKitSettings *webkitSettings = webkit_settings_new();
270270
webkit_settings_set_enable_developer_extras(webkitSettings, TRUE);
271271
webkit_settings_set_enable_webgl(webkitSettings, TRUE);
272+
webkit_settings_set_enable_media_stream(webkitSettings, TRUE);
272273
if (!addSettingsGroupToContext(context, webkitSettings))
273274
g_clear_object(&webkitSettings);
274275

0 commit comments

Comments
 (0)