Skip to content

Commit dce7ca5

Browse files
[GTK] Fix compiler warning in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=161529 We were missing a return statement in decidePermissionRequest() and also there was unused variable in browserWindowConstructed(). Patch by Tomas Popela <[email protected]> on 2016-09-02 Reviewed by Carlos Garcia Campos. * MiniBrowser/gtk/BrowserTab.c: (decidePermissionRequest): * MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@205343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent d4041c6 commit dce7ca5

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

Tools/ChangeLog

+15
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
2016-09-02 Tomas Popela <[email protected]>
2+
3+
[GTK] Fix compiler warning in MiniBrowser
4+
https://bugs.webkit.org/show_bug.cgi?id=161529
5+
6+
We were missing a return statement in decidePermissionRequest() and
7+
also there was unused variable in browserWindowConstructed().
8+
9+
Reviewed by Carlos Garcia Campos.
10+
11+
* MiniBrowser/gtk/BrowserTab.c:
12+
(decidePermissionRequest):
13+
* MiniBrowser/gtk/BrowserWindow.c:
14+
(browserWindowConstructed):
15+
116
2016-09-01 Dan Bernstein <[email protected]>
217

318
Build fix.

Tools/MiniBrowser/gtk/BrowserTab.c

+2
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,8 @@ static gboolean decidePermissionRequest(WebKitWebView *webView, WebKitPermission
225225
gtk_box_pack_start(GTK_BOX(tab), dialog, FALSE, FALSE, 0);
226226
gtk_box_reorder_child(GTK_BOX(tab), dialog, 0);
227227
gtk_widget_show(dialog);
228+
229+
return TRUE;
228230
}
229231

230232
#if GTK_CHECK_VERSION(3, 12, 0)

Tools/MiniBrowser/gtk/BrowserWindow.c

-2
Original file line numberDiff line numberDiff line change
@@ -952,8 +952,6 @@ static void browser_window_init(BrowserWindow *window)
952952

953953
static void browserWindowConstructed(GObject *gObject)
954954
{
955-
BrowserWindow *window = BROWSER_WINDOW(gObject);
956-
957955
G_OBJECT_CLASS(browser_window_parent_class)->constructed(gObject);
958956
}
959957

0 commit comments

Comments
 (0)