Links with empty hrefs should not be drag sources

https://bugs.webkit.org/show_bug.cgi?id=170241
<rdar://problem/31305505>

Reviewed by Tim Horton.

Source/WebCore:

The m_dragSouceAction member of DragController represents the drag source actions that are available to the
document, rather than the available actions given the dragging element. Thus, it is not correct to only check
that (m_dragSourceAction & DragSourceActionAttachment) before proceeding down the attachment dragging codepath.
This should be additionally guarded with a check that the element being dragged is, in fact, an attachment
element.

New API test (see Tools/ChangeLog).

* page/DragController.cpp:
(WebCore::DragController::startDrag):

Tools:

Adds a new API test: DataInteractionTests.LinkWithEmptyHREF.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/ios/DataInteractionSimulator.h:

Expose the current phase of the data interaction simulator for verifying behaviors in unit tests.

* TestWebKitAPI/ios/DataInteractionSimulator.mm:
(-[DataInteractionSimulator phase]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@214556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Source/WebCore/ChangeLog

@@ -1,3 +1,22 @@
+2017-03-29  Wenson Hsieh  <[email protected]>
+
+        Links with empty hrefs should not be drag sources
+        https://bugs.webkit.org/show_bug.cgi?id=170241
+        <rdar://problem/31305505>
+
+        Reviewed by Tim Horton.
+
+        The m_dragSouceAction member of DragController represents the drag source actions that are available to the
+        document, rather than the available actions given the dragging element. Thus, it is not correct to only check
+        that (m_dragSourceAction & DragSourceActionAttachment) before proceeding down the attachment dragging codepath.
+        This should be additionally guarded with a check that the element being dragged is, in fact, an attachment
+        element.
+
+        New API test (see Tools/ChangeLog).
+
+        * page/DragController.cpp:
+        (WebCore::DragController::startDrag):
+
 2017-03-29  Jeremy Jones  <[email protected]>
 
         WebVideoFullscreenInterfaceAVKit needs a strong self ref before dispatching to the main thread.

Source/WebCore/page/DragController.cpp

@@ -1013,7 +1013,7 @@ bool DragController::startDrag(Frame& src, const DragState& state, DragOperation
     }
 
 #if ENABLE(ATTACHMENT_ELEMENT)
-    if (m_dragSourceAction & DragSourceActionAttachment) {
+    if (is<HTMLAttachmentElement>(element) && m_dragSourceAction & DragSourceActionAttachment) {
         if (!dataTransfer.pasteboard().hasData()) {
             selectElement(element);
             if (!attachmentURL.isEmpty()) {

Tools/ChangeLog

@@ -1,3 +1,22 @@
+2017-03-29  Wenson Hsieh  <[email protected]>
+
+        Links with empty hrefs should not be drag sources
+        https://bugs.webkit.org/show_bug.cgi?id=170241
+        <rdar://problem/31305505>
+
+        Reviewed by Tim Horton.
+
+        Adds a new API test: DataInteractionTests.LinkWithEmptyHREF.
+
+        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/ios/DataInteractionSimulator.h:
+
+        Expose the current phase of the data interaction simulator for verifying behaviors in unit tests.
+
+        * TestWebKitAPI/ios/DataInteractionSimulator.mm:
+        (-[DataInteractionSimulator phase]):
+
 2017-03-29  Jonathan Bedard  <[email protected]>
 
         Use TCP instead of FIFOs for Simulator/Device communication

Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm

@@ -172,6 +172,7 @@ - (NSString *)editorValue
     RetainPtr<DataInteractionSimulator> dataInteractionSimulator = adoptNS([[DataInteractionSimulator alloc] initWithWebView:webView.get()]);
     [dataInteractionSimulator runFrom:CGPointMake(100, 50) to:CGPointMake(100, 300)];
 
+    EXPECT_EQ(DataInteractionCancelled, [dataInteractionSimulator phase]);
     EXPECT_FALSE([webView editorContainsImageElement]);
 
     NSArray *observedEventNames = [dataInteractionSimulator observedEventNames];
@@ -292,6 +293,19 @@ - (NSString *)editorValue
     EXPECT_WK_STREQ("PASS", [webView stringByEvaluatingJavaScript:@"target.textContent"].UTF8String);
 }
 
+TEST(DataInteractionTests, LinkWithEmptyHREF)
+{
+    RetainPtr<TestWKWebView> webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
+    [webView synchronouslyLoadTestPageNamed:@"link-and-input"];
+    [webView stringByEvaluatingJavaScript:@"document.querySelector('a').href = ''"];
+
+    RetainPtr<DataInteractionSimulator> dataInteractionSimulator = adoptNS([[DataInteractionSimulator alloc] initWithWebView:webView.get()]);
+    [dataInteractionSimulator runFrom:CGPointMake(100, 50) to:CGPointMake(100, 300)];
+
+    EXPECT_EQ(DataInteractionCancelled, [dataInteractionSimulator phase]);
+    EXPECT_WK_STREQ("", [webView editorValue].UTF8String);
+}
+
 } // namespace TestWebKitAPI
 
 #endif // ENABLE(DATA_INTERACTION)

Tools/TestWebKitAPI/ios/DataInteractionSimulator.h

@@ -71,6 +71,7 @@ typedef NS_ENUM(NSInteger, DataInteractionPhase) {
 @property (nonatomic, strong) UIItemProvider *externalItemProvider;
 @property (nonatomic, readonly) NSArray *observedEventNames;
 @property (nonatomic, readonly) NSArray *finalSelectionRects;
+@property (nonatomic, readonly) DataInteractionPhase phase;
 
 @end
 

Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm

@@ -209,6 +209,11 @@ - (void)setExternalItemProvider:(UIItemProvider *)externalItemProvider
     _externalItemProvider = externalItemProvider;
 }
 
+- (DataInteractionPhase)phase
+{
+    return _phase;
+}
+
 #pragma mark - _WKTestingDelegate
 
 - (void)webViewDidPerformDataInteractionControllerOperation:(WKWebView *)webView