Skip to content

Commit a89fc98

Browse files
committed
updated readme and config
1 parent 49442a6 commit a89fc98

File tree

2 files changed

+23
-2
lines changed

2 files changed

+23
-2
lines changed

README.md

+21-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## DSP app
1+
# dsp-fronted
22

33
## Requirements
44
* node v6 (https://nodejs.org)
@@ -36,3 +36,23 @@ See Guild https://github.com/lorenwest/node-config/wiki/Configuration-Files
3636

3737
## Google Map
3838
In this project module [react-google-maps](https://github.com/tomchentw/react-google-maps) is used to work with google maps. So it can be used for any new functionality.
39+
40+
# Challenges
41+
42+
## [30055900](https://www.topcoder.com/challenge-details/30055900)
43+
## DONE
44+
- All modules were rewritten almost from the scratch because the previous code was very buggy, hard to support and too far from the redux way which is used in the new project. This was the biggest job. Current code is much more robust and is 99% stateless.
45+
- For most important parts detailed unit tests are written.
46+
- Redrawing mission on the map was optimised, no unnecessary redrawing.
47+
- Readme file was cleaned and updated with information about tests and module used to implement google maps for future developers.
48+
49+
## ADDITIONALLY
50+
- These small things from `kbowerma` was added:
51+
- - I know this was not in the challenge req but another thing that would be nice is if the label for PARAM4 changed to “Heading” only if NAV_WAYPOINT is selected. and PARAMA1 label changed to “hold time” only if NAV_WAYPOINT is selected.
52+
- - IT should be, but home and take off should be pinned together with the first click, but then should be able to be dragged or updated with text separately
53+
- All modules integrated with current project styles.
54+
- Test environment was set up. It uses `Mocha`, `Chai` and `Enzyme`. Also, it supports `jsx`, `css-modules` and `webpack resolve aliases`. Even though it's implicitly the scope of the challenge, it was a tangible part.
55+
56+
## NOTES
57+
- As there is no Authorization implemented in the project. In the API I've hardcoded automatic registering and authorization of a dumb user to make requests to the server.
58+
- A lot of files in the repository had the `crlf` line endings. Though `eslint` and `.editorconfig` prescribe using `lf` line endings. So all files were converted to `lf` line endings to pass the linting process and follow configuration.

config/default.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@
55
module.exports = {
66
PORT: process.env.PORT || 3000,
77
GOOGLE_API_KEY: process.env.GOOGLE_API_KEY || 'AIzaSyCrL-O319wNJK8kk8J_JAYsWgu6yo5YsDI',
8-
API_BASE_PATH: process.env.API_BASE_PATH || 'http://localhost:3500',
8+
//API_BASE_PATH: process.env.API_BASE_PATH || 'http://localhost:3000',
9+
API_BASE_PATH: process.env.API_BASE_PATH || 'https://kb-dsp-server-dev.herokuapp.com',
910
};

0 commit comments

Comments
 (0)