Skip to content

Commit f6b112a

Browse files
author
gondzo
committed
Merge branch 'dev'
2 parents 4a802d4 + 83fdaf0 commit f6b112a

File tree

7 files changed

+9
-8
lines changed

7 files changed

+9
-8
lines changed

README.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,18 @@
1010

1111

1212
## Configuration
13-
Configuration files are located under `config` dir.
13+
Configuration files are located under `config` and `src/config` directories.
1414
See Guild https://github.com/lorenwest/node-config/wiki/Configuration-Files
1515

1616
|Name|Description|
1717
|----|-----------|
1818
|`PORT`| The port to listen|
1919
|`GOOGLE_API_KEY`| The google api key see (https://developers.google.com/maps/documentation/javascript/get-api-key#key)|
2020
|`API_BASE_URL`| The base URL for Drone API |
21+
|`REACT_APP_API_BASE_PATH`| The React app api base path`|
22+
|`REACT_APP_SOCKET_URL`| The React app app socket url`|
23+
|`REACT_APP_AUTH0_CLIEND_ID`| The React app auth0 client id`|
24+
|`REACT_APP_AUTH0_DOMAIN`| The React app auth0 domain`|
2125

2226

2327
## Install dependencies

config/default.js

-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ module.exports = {
88

99
// below env variables are visible in frontend
1010
GOOGLE_API_KEY: process.env.GOOGLE_API_KEY || 'AIzaSyCrL-O319wNJK8kk8J_JAYsWgu6yo5YsDI',
11-
API_BASE_PATH: process.env.API_BASE_PATH || 'https://kb-dsp-server-dev.herokuapp.com',
1211
};

config/development.js

-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ module.exports = {
88

99
// below env variables are visible in frontend
1010
GOOGLE_API_KEY: process.env.GOOGLE_API_KEY || 'AIzaSyCrL-O319wNJK8kk8J_JAYsWgu6yo5YsDI',
11-
API_BASE_PATH: process.env.API_BASE_PATH || 'https://kb-dsp-server-dev.herokuapp.com',
1211
};

config/production.js

-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ module.exports = {
88

99
// below env variables are visible in frontend
1010
GOOGLE_API_KEY: process.env.GOOGLE_API_KEY || 'AIzaSyCrL-O319wNJK8kk8J_JAYsWgu6yo5YsDI',
11-
API_BASE_PATH: process.env.API_BASE_PATH || 'https://kb-dsp-server-dev.herokuapp.com',
1211
};

config/staging.js

-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ module.exports = {
88

99
// below env variables are visible in frontend
1010
GOOGLE_API_KEY: process.env.GOOGLE_API_KEY || 'AIzaSyCrL-O319wNJK8kk8J_JAYsWgu6yo5YsDI',
11-
API_BASE_PATH: process.env.API_BASE_PATH || 'https://kb-dsp-server-dev.herokuapp.com',
1211
};

config/test.js

-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ module.exports = {
88

99
// below env variables are visible in frontend
1010
GOOGLE_API_KEY: process.env.GOOGLE_API_KEY || 'AIzaSyCrL-O319wNJK8kk8J_JAYsWgu6yo5YsDI',
11-
API_BASE_PATH: process.env.API_BASE_PATH || 'https://kb-dsp-server-dev.herokuapp.com',
1211
};

webpack.config.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
const path = require('path');
44
const _ = require('lodash');
5-
const ip = require('ip');
65
const webpack = require('webpack');
76
const config = require('config');
87
const HtmlWebpackPlugin = require('html-webpack-plugin');
@@ -100,7 +99,10 @@ module.exports = {
10099
'process.env': {
101100
NODE_ENV: JSON.stringify(process.env.NODE_ENV),
102101
GOOGLE_API_KEY: JSON.stringify(process.env.GOOGLE_API_KEY),
103-
API_BASE_URL: JSON.stringify(process.env.API_BASE_URL),
102+
REACT_APP_API_BASE_PATH: JSON.stringify(process.env.REACT_APP_API_BASE_PATH),
103+
REACT_APP_SOCKET_URL: JSON.stringify(process.env.REACT_APP_SOCKET_URL),
104+
REACT_APP_AUTH0_CLIEND_ID: JSON.stringify(process.env.REACT_APP_AUTH0_CLIEND_ID),
105+
REACT_APP_AUTH0_DOMAIN: JSON.stringify(process.env.REACT_APP_AUTH0_DOMAIN),
104106
},
105107
}),
106108
new HtmlWebpackPlugin({

0 commit comments

Comments
 (0)