Default charset

Author: smarek

library/src/com/loopj/android/http/AsyncHttpResponseHandler.java

@@ -93,7 +93,8 @@ public class AsyncHttpResponseHandler {
     protected static final int BUFFER_SIZE = 4096;
 
     private Handler handler;
-    private String responseCharset = "UTF-8";
+    public static final String DEFAULT_CHARSET = "UTF-8";
+    private String responseCharset = DEFAULT_CHARSET;
     private Boolean useSynchronousMode = false;
 
     // avoid leaks by using a non-anonymous handler class

library/src/com/loopj/android/http/TextHttpResponseHandler.java

@@ -5,15 +5,15 @@
 import java.io.UnsupportedEncodingException;
 
 /**
- * Used to intercept and handle the responses from requests made using 
- * {@link AsyncHttpClient}. The {@link #onSuccess(String)} method is 
+ * Used to intercept and handle the responses from requests made using
+ * {@link AsyncHttpClient}. The {@link #onSuccess(String)} method is
  * designed to be anonymously overridden with your own response handling code.
- * <p>
+ * <p/>
  * Additionally, you can override the {@link #onFailure(String, Throwable)},
  * {@link #onStart()}, and {@link #onFinish()} methods as required.
- * <p>
+ * <p/>
  * For example:
- * <p>
+ * <p/>
  * <pre>
  * AsyncHttpClient client = new AsyncHttpClient();
  * client.get("http://www.google.com", new TextHttpResponseHandler() {
@@ -26,7 +26,7 @@
  *     public void onSuccess(String responseBody) {
  *         // Successfully got a response
  *     }
- * 
+ *
  *     &#064;Override
  *     public void onFailure(String responseBody, Throwable e) {
  *         // Response failed :(
@@ -42,15 +42,15 @@
 public class TextHttpResponseHandler extends AsyncHttpResponseHandler {
 
     private String _encoding;
+
     /**
      * Creates a new TextHttpResponseHandler
      */
-    
-    public TextHttpResponseHandler()
-    {
-        this("UTF-8");
+
+    public TextHttpResponseHandler() {
+        this(DEFAULT_CHARSET);
     }
-    
+
     public TextHttpResponseHandler(String encoding) {
         super();
         _encoding = encoding;
@@ -62,45 +62,45 @@ public TextHttpResponseHandler(String encoding) {
     /**
      * Fired when a request returns successfully, override to handle in your own
      * code
-     * 
+     *
      * @param responseBody the body of the HTTP response from the server
      */
     public void onSuccess(String responseBody) {
     }
-    
+
     /**
      * Fired when a request returns successfully, override to handle in your own
      * code
-     * 
-     * @param statusCode the status code of the response
-     * @param headers HTTP response headers
+     *
+     * @param statusCode   the status code of the response
+     * @param headers      HTTP response headers
      * @param responseBody the body of the HTTP response from the server
      */
     public void onSuccess(int statusCode, Header[] headers, String responseBody) {
-      onSuccess( responseBody );
+        onSuccess(responseBody);
     }
 
     /**
      * Fired when a request fails to complete, override to handle in your own
      * code
-     * 
+     *
      * @param responseBody the response body, if any
-     * @param error the underlying cause of the failure
-     */    
+     * @param error        the underlying cause of the failure
+     */
     public void onFailure(String responseBody, Throwable error) {
     }
-    
+
     /**
      * Fired when a request fails to complete, override to handle in your own
      * code
-     * 
-     * @param statusCode the status code of the response
-     * @param headers HTTP response headers
+     *
+     * @param statusCode   the status code of the response
+     * @param headers      HTTP response headers
      * @param responseBody the response body, if any
-     * @param error the underlying cause of the failure
-     */    
+     * @param error        the underlying cause of the failure
+     */
     public void onFailure(int statusCode, Header[] headers, String responseBody, Throwable error) {
-      onFailure( responseBody, error );
+        onFailure(responseBody, error);
     }
 
     @Override
@@ -120,5 +120,5 @@ public void onFailure(int statusCode, Header[] headers, byte[] responseBody, Thr
             onFailure(0, headers, (String) null, e);
         }
     }
-    
+
 }