Skip to content

Commit fee6e95

Browse files
committed
Fixed Exceeds icon on questioned/failed requirements
1 parent e90c7ea commit fee6e95

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

frontend/dist/scripts/app.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -845,7 +845,6 @@ function buildReview() {
845845

846846
// building incorrect items
847847
gradedData.incorrectItems.forEach(item => {
848-
console.log(item)
849848
let li = document.createElement('li');
850849
li.classList = 'incorrect';
851850
const div1 = document.createElement('div');
@@ -857,7 +856,6 @@ function buildReview() {
857856
const div2 = document.createElement('div2');
858857
div2.classList.add('req-content');
859858
let req = document.createElement('span');
860-
console.log(item)
861859
const requirement = item.req.querySelector('.sub-requirements-title');
862860
req.textContent = requirement.textContent;
863861
div2.appendChild(req);
@@ -1036,15 +1034,15 @@ function copySlackMessage() {
10361034
gradedData.questionableItems.forEach(item => {
10371035
const requirement = item.req.querySelector('.sub-requirements-title');
10381036
const isExceeds = item.req.classList.contains('exceeds-item');
1039-
secretTextarea.value += `:questioned: ${isExceeds && ":exceeds:"} ${requirement.textContent}\n> ${item.text}\n`
1037+
secretTextarea.value += `:questioned: ${isExceeds ? ":exceeds:" : ''} ${requirement.textContent}\n> ${item.text}\n`
10401038
})
10411039
secretTextarea.value += `\n`
10421040
}
10431041
if (toggle_wrong.classList.contains('active')) {
10441042
gradedData.incorrectItems.forEach(item => {
10451043
const requirement = item.req.querySelector('.sub-requirements-title');
10461044
const isExceeds = item.req.classList.contains('exceeds-item');
1047-
secretTextarea.value += `:needs-work: ${isExceeds && ":exceeds:"} ${requirement.textContent}\n> ${item.text}\n`
1045+
secretTextarea.value += `:needs-work: ${isExceeds ? ":exceeds:" : ''} ${requirement.textContent}\n> ${item.text}\n`
10481046
})
10491047
}
10501048

frontend/src/scripts/app.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1034,15 +1034,15 @@ function copySlackMessage() {
10341034
gradedData.questionableItems.forEach(item => {
10351035
const requirement = item.req.querySelector('.sub-requirements-title');
10361036
const isExceeds = item.req.classList.contains('exceeds-item');
1037-
secretTextarea.value += `:questioned: ${isExceeds && ":exceeds:"} ${requirement.textContent}\n> ${item.text}\n`
1037+
secretTextarea.value += `:questioned: ${isExceeds ? ":exceeds:" : ''} ${requirement.textContent}\n> ${item.text}\n`
10381038
})
10391039
secretTextarea.value += `\n`
10401040
}
10411041
if (toggle_wrong.classList.contains('active')) {
10421042
gradedData.incorrectItems.forEach(item => {
10431043
const requirement = item.req.querySelector('.sub-requirements-title');
10441044
const isExceeds = item.req.classList.contains('exceeds-item');
1045-
secretTextarea.value += `:needs-work: ${isExceeds && ":exceeds:"} ${requirement.textContent}\n> ${item.text}\n`
1045+
secretTextarea.value += `:needs-work: ${isExceeds ? ":exceeds:" : ''} ${requirement.textContent}\n> ${item.text}\n`
10461046
})
10471047
}
10481048

0 commit comments

Comments
 (0)