Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: certifi/python-certifi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tsibley/python-certifi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Sep 13, 2022

  1. Only use importlib.resources's new files() / Traversable API on Pytho… 

    …n ≥3.11

Using importlib.resource's files() API on 3.9 and 3.10 causes a
TypeError on 3.9 and a ValueError on 3.10 when running under a
third-party meta path importer (like PyOxidizer's OxidizedImporter) that
doesn't support the relatively-new API.  This is because the full
adapter layer (importlib.resources._adapters) for the older importlib
resources API doesn't exist until Python 3.11.

The older resources API is now used by 3.7–3.10, as it was prior to the
certifi 2022.06.15.1 release.  This codepath has existed in certifi
since April 2020 (3fc8fec).

An alternative to this change would be testing the actual importer in
use at runtime (e.g. certifi.__loader__) for files() support, but that
seemed more complex than reverting to the previous codepath here.

Resolves: #203
Related-to: #199
Related-to: #123
    @tsibley
    tsibley committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    38e727c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'only-use-new-importlib-on-3.11' into master-maybe

    @tsibley
    tsibley committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    10ae450 View commit details
    Browse the repository at this point in the history
Loading