minor clean up

slandelle · slandelle · commit 1f9dea2fc907 · 2015-07-09T16:06:36.000+02:00
diff --git a/providers/netty3/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java b/providers/netty3/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
@@ -363,17 +363,13 @@ private HttpClientCodec newHttpClientCodec() {
                 config.getHttpClientCodecMaxChunkSize());
     }
 
-    public SslHandler createSslHandler(String peerHost, int peerPort) throws GeneralSecurityException, IOException {
+    private SslHandler createSslHandler(String peerHost, int peerPort) throws GeneralSecurityException, IOException {
         SSLEngine sslEngine = sslEngineFactory.newSSLEngine(peerHost, peerPort);
         SslHandler sslHandler = handshakeTimeout > 0 ? new SslHandler(sslEngine, getDefaultBufferPool(), false, nettyTimer, handshakeTimeout) : new SslHandler(sslEngine);
         sslHandler.setCloseOnSSLException(true);
         return sslHandler;
     }
 
-    public static SslHandler getSslHandler(ChannelPipeline pipeline) {
-        return (SslHandler) pipeline.get(SSL_HANDLER);
-    }
-
     public static boolean isSslHandlerConfigured(ChannelPipeline pipeline) {
         return pipeline.get(SSL_HANDLER) != null;
     }
diff --git a/providers/netty4/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java b/providers/netty4/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
@@ -340,18 +340,14 @@ private HttpClientCodec newHttpClientCodec() {
                 false);
     }
 
-    public SslHandler createSslHandler(String peerHost, int peerPort) throws IOException, GeneralSecurityException {
+    private SslHandler createSslHandler(String peerHost, int peerPort) throws IOException, GeneralSecurityException {
         SSLEngine sslEngine = sslEngineFactory.newSSLEngine(peerHost, peerPort);
         SslHandler sslHandler = new SslHandler(sslEngine);
         if (handshakeTimeout > 0)
             sslHandler.setHandshakeTimeoutMillis(handshakeTimeout);
         return sslHandler;
     }
 
-    public static SslHandler getSslHandler(ChannelPipeline pipeline) {
-        return (SslHandler) pipeline.get(SSL_HANDLER);
-    }
-
     public static boolean isSslHandlerConfigured(ChannelPipeline pipeline) {
         return pipeline.get(SSL_HANDLER) != null;
     }

Original file line number	Diff line number	Diff line change
`@@ -363,17 +363,13 @@ private HttpClientCodec newHttpClientCodec() {`
`363`	`363`	`config.getHttpClientCodecMaxChunkSize());`
`364`	`364`	`}`
`365`	`365`
`366`		`- public SslHandler createSslHandler(String peerHost, int peerPort) throws GeneralSecurityException, IOException {`
	`366`	`+ private SslHandler createSslHandler(String peerHost, int peerPort) throws GeneralSecurityException, IOException {`
`367`	`367`	`SSLEngine sslEngine = sslEngineFactory.newSSLEngine(peerHost, peerPort);`
`368`	`368`	`SslHandler sslHandler = handshakeTimeout > 0 ? new SslHandler(sslEngine, getDefaultBufferPool(), false, nettyTimer, handshakeTimeout) : new SslHandler(sslEngine);`
`369`	`369`	`sslHandler.setCloseOnSSLException(true);`
`370`	`370`	`return sslHandler;`
`371`	`371`	`}`
`372`	`372`
`373`		`- public static SslHandler getSslHandler(ChannelPipeline pipeline) {`
`374`		`- return (SslHandler) pipeline.get(SSL_HANDLER);`
`375`		`- }`
`376`		`-`
`377`	`373`	`public static boolean isSslHandlerConfigured(ChannelPipeline pipeline) {`
`378`	`374`	`return pipeline.get(SSL_HANDLER) != null;`
`379`	`375`	`}`
Original file line number	Diff line number	Diff line change
`@@ -340,18 +340,14 @@ private HttpClientCodec newHttpClientCodec() {`
`340`	`340`	`false);`
`341`	`341`	`}`
`342`	`342`
`343`		`- public SslHandler createSslHandler(String peerHost, int peerPort) throws IOException, GeneralSecurityException {`
	`343`	`+ private SslHandler createSslHandler(String peerHost, int peerPort) throws IOException, GeneralSecurityException {`
`344`	`344`	`SSLEngine sslEngine = sslEngineFactory.newSSLEngine(peerHost, peerPort);`
`345`	`345`	`SslHandler sslHandler = new SslHandler(sslEngine);`
`346`	`346`	`if (handshakeTimeout > 0)`
`347`	`347`	`sslHandler.setHandshakeTimeoutMillis(handshakeTimeout);`
`348`	`348`	`return sslHandler;`
`349`	`349`	`}`
`350`	`350`
`351`		`- public static SslHandler getSslHandler(ChannelPipeline pipeline) {`
`352`		`- return (SslHandler) pipeline.get(SSL_HANDLER);`
`353`		`- }`
`354`		`-`
`355`	`351`	`public static boolean isSslHandlerConfigured(ChannelPipeline pipeline) {`
`356`	`352`	`return pipeline.get(SSL_HANDLER) != null;`
`357`	`353`	`}`