Skip to content

Commit ce5f0a9

Browse files
committed
Fix test: X-redirect is propagated on redirect
1 parent 34ef0c2 commit ce5f0a9

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

api/src/test/java/org/asynchttpclient/HttpToHttpsRedirectTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838

3939
public abstract class HttpToHttpsRedirectTest extends AbstractBasicTest {
4040

41+
// FIXME super NOT threadsafe!!!
4142
private final AtomicBoolean redirectDone = new AtomicBoolean(false);
4243

4344
private class Relative302Handler extends AbstractHandler {
@@ -142,7 +143,7 @@ public void relativeLocationUrl() throws Exception {
142143
try (AsyncHttpClient c = getAsyncHttpClient(cg)) {
143144
Response response = c.prepareGet(getTargetUrl()).setHeader("X-redirect", "/foo/test").execute().get();
144145
assertNotNull(response);
145-
assertEquals(response.getStatusCode(), 302);
146+
assertEquals(response.getStatusCode(), 200);
146147
assertEquals(response.getUri().toString(), getTargetUrl());
147148
}
148149
}

api/src/test/java/org/asynchttpclient/PerRequestRelative302Test.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141

4242
public abstract class PerRequestRelative302Test extends AbstractBasicTest {
4343

44+
// FIXME super NOT threadsafe!!!
4445
private final AtomicBoolean isSet = new AtomicBoolean(false);
4546

4647
private class Relative302Handler extends AbstractHandler {
@@ -152,7 +153,7 @@ public void relativeLocationUrl() throws Exception {
152153
try (AsyncHttpClient c = getAsyncHttpClient(null)) {
153154
Response response = c.preparePost(getTargetUrl()).setFollowRedirect(true).setHeader("X-redirect", "/foo/test").execute().get();
154155
assertNotNull(response);
155-
assertEquals(response.getStatusCode(), 302);
156+
assertEquals(response.getStatusCode(), 200);
156157
assertEquals(response.getUri().toString(), getTargetUrl());
157158
}
158159
}

0 commit comments

Comments
 (0)