Skip to content

Commit 5f10740

Browse files
Allan Sandfeld Jensenpatricia-gallardo
authored andcommitted
Fix building against Qt 5.14
QString::SkipEmptyParts was replaced and deprecated in 5.15 not 5.14. Change-Id: I9585250b4d1781f87567aff957f8b35fb6015647 Reviewed-by: Kirill Burtsev <[email protected]>
1 parent 7b03d0b commit 5f10740

File tree

2 files changed

+28
-6
lines changed

2 files changed

+28
-6
lines changed

tests/auto/quick/qquickwebengineview/tst_qquickwebengineview.cpp

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -993,7 +993,6 @@ void tst_QQuickWebEngineView::inputEventForwardingDisabledWhenActiveFocusOnPress
993993

994994
void tst_QQuickWebEngineView::changeLocale()
995995
{
996-
#if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
997996
QStringList errorLines;
998997
QUrl url("http://non.existent/");
999998

@@ -1004,7 +1003,11 @@ void tst_QQuickWebEngineView::changeLocale()
10041003

10051004
QTRY_VERIFY(!evaluateJavaScriptSync(viewDE.data(), "document.body").isNull());
10061005
QTRY_VERIFY(!evaluateJavaScriptSync(viewDE.data(), "document.body.innerText").isNull());
1006+
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
10071007
errorLines = evaluateJavaScriptSync(viewDE.data(), "document.body.innerText").toString().split(QRegularExpression("[\r\n]"), Qt::SkipEmptyParts);
1008+
#else
1009+
errorLines = evaluateJavaScriptSync(viewDE.data(), "document.body.innerText").toString().split(QRegularExpression("[\r\n]"), QString::SkipEmptyParts);
1010+
#endif
10081011
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("Die Website ist nicht erreichbar"));
10091012

10101013
QLocale::setDefault(QLocale("en"));
@@ -1014,7 +1017,11 @@ void tst_QQuickWebEngineView::changeLocale()
10141017

10151018
QTRY_VERIFY(!evaluateJavaScriptSync(viewEN.data(), "document.body").isNull());
10161019
QTRY_VERIFY(!evaluateJavaScriptSync(viewEN.data(), "document.body.innerText").isNull());
1020+
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
10171021
errorLines = evaluateJavaScriptSync(viewEN.data(), "document.body.innerText").toString().split(QRegularExpression("[\r\n]"), Qt::SkipEmptyParts);
1022+
#else
1023+
errorLines = evaluateJavaScriptSync(viewEN.data(), "document.body.innerText").toString().split(QRegularExpression("[\r\n]"), QString::SkipEmptyParts);
1024+
#endif
10181025
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("This site can\xE2\x80\x99t be reached"));
10191026

10201027
// Reset error page
@@ -1027,9 +1034,12 @@ void tst_QQuickWebEngineView::changeLocale()
10271034

10281035
QTRY_VERIFY(!evaluateJavaScriptSync(viewDE.data(), "document.body").isNull());
10291036
QTRY_VERIFY(!evaluateJavaScriptSync(viewDE.data(), "document.body.innerText").isNull());
1037+
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
10301038
errorLines = evaluateJavaScriptSync(viewDE.data(), "document.body.innerText").toString().split(QRegularExpression("[\r\n]"), Qt::SkipEmptyParts);
1031-
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("Die Website ist nicht erreichbar"));
1039+
#else
1040+
errorLines = evaluateJavaScriptSync(viewDE.data(), "document.body.innerText").toString().split(QRegularExpression("[\r\n]"), QString::SkipEmptyParts);
10321041
#endif
1042+
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("Die Website ist nicht erreichbar"));
10331043
}
10341044

10351045
void tst_QQuickWebEngineView::userScripts()

tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1203,7 +1203,6 @@ void tst_QWebEngineView::doNotBreakLayout()
12031203

12041204
void tst_QWebEngineView::changeLocale()
12051205
{
1206-
#if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
12071206
QStringList errorLines;
12081207
QUrl url("http://non.existent/");
12091208

@@ -1214,7 +1213,11 @@ void tst_QWebEngineView::changeLocale()
12141213
QTRY_COMPARE_WITH_TIMEOUT(loadFinishedSpyDE.count(), 1, 20000);
12151214

12161215
QTRY_VERIFY(!toPlainTextSync(viewDE.page()).isEmpty());
1216+
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
12171217
errorLines = toPlainTextSync(viewDE.page()).split(QRegularExpression("[\r\n]"), Qt::SkipEmptyParts);
1218+
#else
1219+
errorLines = toPlainTextSync(viewDE.page()).split(QRegularExpression("[\r\n]"), QString::SkipEmptyParts);
1220+
#endif
12181221
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("Die Website ist nicht erreichbar"));
12191222

12201223
QLocale::setDefault(QLocale("en"));
@@ -1224,7 +1227,11 @@ void tst_QWebEngineView::changeLocale()
12241227
QTRY_COMPARE_WITH_TIMEOUT(loadFinishedSpyEN.count(), 1, 20000);
12251228

12261229
QTRY_VERIFY(!toPlainTextSync(viewEN.page()).isEmpty());
1230+
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
12271231
errorLines = toPlainTextSync(viewEN.page()).split(QRegularExpression("[\r\n]"), Qt::SkipEmptyParts);
1232+
#else
1233+
errorLines = toPlainTextSync(viewEN.page()).split(QRegularExpression("[\r\n]"), QString::SkipEmptyParts);
1234+
#endif
12281235
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("This site can\xE2\x80\x99t be reached"));
12291236

12301237
// Reset error page
@@ -1237,9 +1244,12 @@ void tst_QWebEngineView::changeLocale()
12371244
QTRY_COMPARE_WITH_TIMEOUT(loadFinishedSpyDE.count(), 1, 20000);
12381245

12391246
QTRY_VERIFY(!toPlainTextSync(viewDE.page()).isEmpty());
1247+
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
12401248
errorLines = toPlainTextSync(viewDE.page()).split(QRegularExpression("[\r\n]"), Qt::SkipEmptyParts);
1241-
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("Die Website ist nicht erreichbar"));
1249+
#else
1250+
errorLines = toPlainTextSync(viewDE.page()).split(QRegularExpression("[\r\n]"), QString::SkipEmptyParts);
12421251
#endif
1252+
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("Die Website ist nicht erreichbar"));
12431253
}
12441254

12451255
void tst_QWebEngineView::inputMethodsTextFormat_data()
@@ -1691,7 +1701,6 @@ void tst_QWebEngineView::touchTapAndHoldCancelled()
16911701

16921702
void tst_QWebEngineView::postData()
16931703
{
1694-
#if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
16951704
QMap<QString, QString> postData;
16961705
// use reserved characters to make the test harder to pass
16971706
postData[QStringLiteral("Spä=m")] = QStringLiteral("ëgg:s");
@@ -1713,7 +1722,11 @@ void tst_QWebEngineView::postData()
17131722
QStringList lines = QString::fromLocal8Bit(rawData).split("\r\n");
17141723

17151724
// examine request
1725+
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
17161726
QStringList request = lines[0].split(" ", Qt::SkipEmptyParts);
1727+
#else
1728+
QStringList request = lines[0].split(" ", QString::SkipEmptyParts);
1729+
#endif
17171730
bool requestOk = request.length() > 2
17181731
&& request[2].toUpper().startsWith("HTTP/")
17191732
&& request[0].toUpper() == "POST"
@@ -1819,7 +1832,6 @@ void tst_QWebEngineView::postData()
18191832

18201833
timeoutGuard.stop();
18211834
server.close();
1822-
#endif
18231835
}
18241836

18251837
void tst_QWebEngineView::inputFieldOverridesShortcuts()

0 commit comments

Comments
 (0)