Skip to content

Commit 6f76ff5

Browse files
Allan Sandfeld Jensenpatricia-gallardo
authored andcommitted
Fix building against 5.12 on most CIs
Change-Id: I4c4bbc75b9f6346a446f8094f669d142f76c164a Reviewed-by: Kirill Burtsev <[email protected]>
1 parent f1e6890 commit 6f76ff5

File tree

7 files changed

+26
-4
lines changed

7 files changed

+26
-4
lines changed

configure.pri

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -461,10 +461,17 @@ defineTest(qtwebengine_isMacOsPlatformSupported) {
461461

462462
defineTest(qtwebengine_isGCCVersionSupported) {
463463
# Keep in sync with src/webengine/doc/src/qtwebengine-platform-notes.qdoc
464-
greaterThan(QMAKE_GCC_MAJOR_VERSION, 4):return(true)
464+
lessThan(QMAKE_GCC_MAJOR_VERSION, 5) {
465+
qtwebengine_platformError("requires at least gcc version 5, but using gcc version $${QMAKE_GCC_MAJOR_VERSION}.$${QMAKE_GCC_MINOR_VERSION}.")
466+
return(false)
467+
}
465468

466-
qtwebengine_platformError("requires at least gcc version 5, but using gcc version $${QMAKE_GCC_MAJOR_VERSION}.$${QMAKE_GCC_MINOR_VERSION}.")
467-
return(false)
469+
equals(QMAKE_GCC_MAJOR_VERSION, 5): equals(QMAKE_GCC_MINOR_VERSION, 4): equals(QMAKE_GCC_PATCH_VERSION, 0) {
470+
qtwebengine_platformError("gcc version 5.4.0 is blacklisted due to internal compiler errors.")
471+
return(false)
472+
}
473+
474+
return(true)
468475
}
469476

470477
defineTest(qtwebengine_isBuildingOnWin32) {

src/pdf/config/ios.pri

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ clang_base_path=\"$${clang_dir}\" \
3737
ios_enable_code_signing=false \
3838
target_os=\"ios\" \
3939
ios_deployment_target=\"$${QMAKE_IOS_DEPLOYMENT_TARGET}\" \
40+
mac_sdk_min=\"$${QMAKE_MAC_SDK_VERSION_MAJOR_MINOR}\" \
4041
enable_ios_bitcode=true \
4142
use_jumbo_build=false
4243

src/pdf/configure.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"module": "pdf",
33
"depends" : [ "buildtools-private" ],
44
"testDir": "../../config.tests",
5-
"condition": "features.build-qtpdf && features.webengine-qtpdf-support",
5+
"condition": "module.gui && features.webengine-qtpdf-support && features.build-qtpdf",
66
"libraries": {
77
},
88
"tests": {

tests/auto/quick/qquickwebengineview/tst_qquickwebengineview.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -993,6 +993,7 @@ void tst_QQuickWebEngineView::inputEventForwardingDisabledWhenActiveFocusOnPress
993993

994994
void tst_QQuickWebEngineView::changeLocale()
995995
{
996+
#if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
996997
QStringList errorLines;
997998
QUrl url("http://non.existent/");
998999

@@ -1028,6 +1029,7 @@ void tst_QQuickWebEngineView::changeLocale()
10281029
QTRY_VERIFY(!evaluateJavaScriptSync(viewDE.data(), "document.body.innerText").isNull());
10291030
errorLines = evaluateJavaScriptSync(viewDE.data(), "document.body.innerText").toString().split(QRegularExpression("[\r\n]"), Qt::SkipEmptyParts);
10301031
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("Die Website ist nicht erreichbar"));
1032+
#endif
10311033
}
10321034

10331035
void tst_QQuickWebEngineView::userScripts()
@@ -1173,6 +1175,9 @@ void tst_QQuickWebEngineView::focusChild_data()
11731175

11741176
void tst_QQuickWebEngineView::focusChild()
11751177
{
1178+
#if QT_VERSION < QT_VERSION_CHECK(5, 14, 1)
1179+
QSKIP("Requires newer base Qt");
1180+
#endif
11761181
auto traverseToWebDocumentAccessibleInterface = [](QAccessibleInterface *iface) -> QAccessibleInterface * {
11771182
QFETCH(QVector<QAccessible::Role>, ancestorRoles);
11781183
for (int i = 0; i < ancestorRoles.size(); ++i) {

tests/auto/quick/quick.pro

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,7 @@ qtConfig(webengine-testsupport) {
2020

2121
qtConfig(ssl): SUBDIRS += qmltests_ssl
2222

23+
lessThan(QT_MAJOR_VERSION, 6):lessThan(QT_MINOR_VERSION, 14): SUBDIRS -= qmltests qmltests2 qmltests_ssl
24+
2325
# QTBUG-66055
2426
boot2qt: SUBDIRS -= inspectorserver qquickwebengineview qmltests qmltests2

tests/auto/widgets/accessibility/tst_accessibility.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,9 @@ void tst_Accessibility::focusChild_data()
160160

161161
void tst_Accessibility::focusChild()
162162
{
163+
#if QT_VERSION < QT_VERSION_CHECK(5, 14, 1)
164+
QSKIP("Requires newer base Qt");
165+
#endif
163166
auto traverseToWebDocumentAccessibleInterface = [](QAccessibleInterface *iface) -> QAccessibleInterface * {
164167
QFETCH(QVector<QAccessible::Role>, ancestorRoles);
165168
for (int i = 0; i < ancestorRoles.size(); ++i) {

tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1203,6 +1203,7 @@ void tst_QWebEngineView::doNotBreakLayout()
12031203

12041204
void tst_QWebEngineView::changeLocale()
12051205
{
1206+
#if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
12061207
QStringList errorLines;
12071208
QUrl url("http://non.existent/");
12081209

@@ -1238,6 +1239,7 @@ void tst_QWebEngineView::changeLocale()
12381239
QTRY_VERIFY(!toPlainTextSync(viewDE.page()).isEmpty());
12391240
errorLines = toPlainTextSync(viewDE.page()).split(QRegularExpression("[\r\n]"), Qt::SkipEmptyParts);
12401241
QCOMPARE(errorLines.first().toUtf8(), QByteArrayLiteral("Die Website ist nicht erreichbar"));
1242+
#endif
12411243
}
12421244

12431245
void tst_QWebEngineView::inputMethodsTextFormat_data()
@@ -1689,6 +1691,7 @@ void tst_QWebEngineView::touchTapAndHoldCancelled()
16891691

16901692
void tst_QWebEngineView::postData()
16911693
{
1694+
#if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
16921695
QMap<QString, QString> postData;
16931696
// use reserved characters to make the test harder to pass
16941697
postData[QStringLiteral("Spä=m")] = QStringLiteral("ëgg:s");
@@ -1816,6 +1819,7 @@ void tst_QWebEngineView::postData()
18161819

18171820
timeoutGuard.stop();
18181821
server.close();
1822+
#endif
18191823
}
18201824

18211825
void tst_QWebEngineView::inputFieldOverridesShortcuts()

0 commit comments

Comments
 (0)