Set off-the-record to true as documented

The API had no way of setting off-the-record, because the constructor
meant for it set it to false. The patch fixes the constructor and
adds basic API tests for the QWebEngineProfiles.

Change-Id: I407eb4a4b0524b6c4eb944d17d744620dd9db6fb
Task-number: QTBUG-48724
Reviewed-by: Kai Koehne <[email protected]>

Author: carewolf

src/webenginewidgets/api/qwebengineprofile.cpp

@@ -193,7 +193,7 @@ void QWebEngineProfilePrivate::downloadUpdated(const DownloadItemInfo &info)
 */
 QWebEngineProfile::QWebEngineProfile(QObject *parent)
     : QObject(parent)
-    , d_ptr(new QWebEngineProfilePrivate(new BrowserContextAdapter(false)))
+    , d_ptr(new QWebEngineProfilePrivate(new BrowserContextAdapter(true)))
 {
     d_ptr->q_ptr = this;
 }

tests/auto/widgets/qwebengineprofile/qwebengineprofile.pro

@@ -0,0 +1,3 @@
+include(../tests.pri)
+exists($${TARGET}.qrc):RESOURCES += $${TARGET}.qrc
+QT *= core-private gui-private

tests/auto/widgets/qwebengineprofile/tst_qwebengineprofile.cpp

@@ -0,0 +1,76 @@
+/****************************************************************************
+**
+** Copyright (C) 2015 The Qt Company Ltd.
+** Contact: http://www.qt.io/licensing/
+**
+** This file is part of the QtWebEngine module of the Qt Toolkit.
+**
+** $QT_BEGIN_LICENSE:LGPL$
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and The Qt Company. For licensing terms
+** and conditions see http://www.qt.io/terms-conditions. For further
+** information use the contact form at http://www.qt.io/contact-us.
+**
+** GNU Lesser General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU Lesser
+** General Public License version 3 as published by the Free Software
+** Foundation and appearing in the file LICENSE.LGPLv3 included in the
+** packaging of this file. Please review the following information to
+** ensure the GNU Lesser General Public License version 3 requirements
+** will be met: https://www.gnu.org/licenses/lgpl.html.
+**
+** GNU General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU
+** General Public License version 2.0 or later as published by the Free
+** Software Foundation and appearing in the file LICENSE.GPL included in
+** the packaging of this file. Please review the following information to
+** ensure the GNU General Public License version 2.0 requirements will be
+** met: http://www.gnu.org/licenses/gpl-2.0.html.
+**
+** $QT_END_LICENSE$
+**
+****************************************************************************/
+
+#include "../util.h"
+#include <QtTest/QtTest>
+#include <qwebengineprofile.h>
+
+class tst_QWebEngineProfile : public QObject
+{
+    Q_OBJECT
+
+private Q_SLOTS:
+    void defaultProfile();
+    void profileConstructors();
+};
+
+void tst_QWebEngineProfile::defaultProfile()
+{
+    QWebEngineProfile *profile = QWebEngineProfile::defaultProfile();
+    QVERIFY(profile);
+    QVERIFY(!profile->isOffTheRecord());
+    QCOMPARE(profile->storageName(), QStringLiteral("Default"));
+    QCOMPARE(profile->httpCacheType(), QWebEngineProfile::DiskHttpCache);
+    QCOMPARE(profile->persistentCookiesPolicy(), QWebEngineProfile::AllowPersistentCookies);
+}
+
+void tst_QWebEngineProfile::profileConstructors()
+{
+    QWebEngineProfile otrProfile;
+    QWebEngineProfile diskProfile(QStringLiteral("Test"));
+
+    QVERIFY(otrProfile.isOffTheRecord());
+    QVERIFY(!diskProfile.isOffTheRecord());
+    QCOMPARE(diskProfile.storageName(), QStringLiteral("Test"));
+    QCOMPARE(otrProfile.httpCacheType(), QWebEngineProfile::MemoryHttpCache);
+    QCOMPARE(diskProfile.httpCacheType(), QWebEngineProfile::DiskHttpCache);
+    QCOMPARE(otrProfile.persistentCookiesPolicy(), QWebEngineProfile::NoPersistentCookies);
+    QCOMPARE(diskProfile.persistentCookiesPolicy(), QWebEngineProfile::AllowPersistentCookies);
+
+}
+
+QTEST_MAIN(tst_QWebEngineProfile)
+#include "tst_qwebengineprofile.moc"

tests/auto/widgets/widgets.pro

@@ -6,8 +6,9 @@ SUBDIRS += \
     qwebengineaccessibility \
     qwebengineframe \
     qwebenginepage \
-    qwebenginehistoryinterface \
-    qwebengineview \
     qwebenginehistory \
+    qwebenginehistoryinterface \
     qwebengineinspector \
+    qwebengineprofile \
     qwebenginescript \
+    qwebengineview