Fix detection of ozone x11 support

Michal Klocek · Michal Klocek · commit bb2a0bbd7101 · 2019-07-12T11:42:05.000+02:00
Fixes: QTBUG-77011
Change-Id: I0136b360c74970b912124f6f308f598c80eceba3
Reviewed-by: Allan Sandfeld Jensen &lt;allan.jensen@qt.io&gt;
diff --git a/mkspecs/features/configure.prf b/mkspecs/features/configure.prf
@@ -94,13 +94,9 @@ defineTest(runConfigure) {
             }
          }
 
-        !qtConfig(webengine-embedded-build): qtConfig(xcb) {
-             for(package, $$list("libdrm xcomposite xcursor xi xtst")) {
-                 !qtConfig(webengine-system-$$package) {
-                     skipBuild("A suitable version of $$package could not be found.")
-                     return(false)
-                 }
-             }
+        !qtConfig(webengine-embedded-build): qtConfig(xcb) : !qtConfig(webengine-ozone-x11) {
+            skipBuild("Could not find all necessary libraries for qpa-xcb support")
+            return(false)
         }
     }
 }
diff --git a/mkspecs/features/functions.prf b/mkspecs/features/functions.prf
@@ -121,11 +121,3 @@ defineReplace(pkgConfigHostExecutable) {
     return($$system_quote($$system_path($$wrapper_name)))
 }
 
-defineTest(hasX11Dependencies) {
-    for(package, $$list("libdrm xcomposite xcursor xi xtst")) {
-        !qtConfig(webengine-system-$$package) {
-            return(false)
-        }
-    }
-    return(true)
-}
diff --git a/src/core/config/linux.pri b/src/core/config/linux.pri
@@ -175,7 +175,7 @@ host_build {
     }
     !packagesExist(libpci): gn_args += use_libpci=false
 
-    qtConfig(webengine-system-x11): hasX11Dependencies() {
+    qtConfig(webengine-ozone-x11) {
         gn_args += ozone_platform_x11=true
         packagesExist(xscrnsaver): gn_args += use_xscrnsaver=true
     }
diff --git a/src/core/configure.json b/src/core/configure.json
@@ -642,6 +642,17 @@
             "condition": "config.unix && libs.webengine-x11",
             "output": [ "privateFeature" ]
         },
+        "webengine-ozone-x11" : {
+             "label": "Support qpa-xcb",
+             "condition": "config.unix
+                          && features.webengine-system-x11
+                          && features.webengine-system-libdrm
+                          && features.webengine-system-xcomposite
+                          && features.webengine-system-xcursor
+                          && features.webengine-system-xi
+                          && features.webengine-system-xtst",
+             "output": [ "privateFeature" ]
+        },
         "webengine-sanitizer" : {
             "label": "Sanitizer",
             "autoDetect": "config.sanitizer && tests.webengine-sanitizer",
@@ -730,6 +741,11 @@
                 "webengine-webchannel",
                 "webengine-v8-snapshot",
                 "webengine-kerberos",
+                {
+                    "type": "feature",
+                    "args": "webengine-ozone-x11",
+                    "condition": "config.unix"
+                },
                 {
                     "type": "feature",
                     "args": "webengine-v8-snapshot-support",
@@ -802,8 +818,7 @@
                         "webengine-system-png",
                         "webengine-system-jpeg",
                         "webengine-system-harfbuzz",
-                        "webengine-system-freetype",
-                        "webengine-system-x11"
+                        "webengine-system-freetype"
                     ]
                 },
                 {
@@ -821,6 +836,7 @@
                    "section": "Required system libraries for qpa-xcb",
                    "condition": "config.unix && !config.macos",
                    "entries": [
+                        "webengine-system-x11",
                         "webengine-system-libdrm",
                         "webengine-system-xcomposite",
                         "webengine-system-xcursor",
diff --git a/src/core/core_chromium.pri b/src/core/core_chromium.pri
@@ -219,7 +219,7 @@ HEADERS = \
         web_event_factory.h
 
 
-qtConfig(webengine-system-x11): hasX11Dependencies() {
+qtConfig(webengine-ozone-x11) {
     HEADERS += ozone/gl_ozone_glx_qt.h \
                ozone/gl_surface_glx_qt.h
     SOURCES += ozone/gl_surface_glx_qt.cpp \
diff --git a/src/core/ozone/surface_factory_qt.cpp b/src/core/ozone/surface_factory_qt.cpp
@@ -41,7 +41,7 @@
 #include "qtwebenginecoreglobal_p.h"
 #include "gl_context_qt.h"
 #include "gl_ozone_egl_qt.h"
-#if QT_CONFIG(webengine_system_x11)
+#if QT_CONFIG(webengine_ozone_x11)
 #include "gl_ozone_glx_qt.h"
 #endif
 
@@ -58,7 +58,7 @@ namespace QtWebEngineCore {
 SurfaceFactoryQt::SurfaceFactoryQt()
 {
     Q_ASSERT(qApp);
-#if QT_CONFIG(webengine_system_x11)
+#if QT_CONFIG(webengine_ozone_x11)
     if (GLContextHelper::getGlXConfig()) {
         m_impl = gl::kGLImplementationDesktopGL;
         m_ozone.reset(new ui::GLOzoneGLXQt());

Original file line number	Diff line number	Diff line change
`@@ -94,13 +94,9 @@ defineTest(runConfigure) {`
`94`	`94`	`}`
`95`	`95`	`}`
`96`	`96`
`97`		`- !qtConfig(webengine-embedded-build): qtConfig(xcb) {`
`98`		`- for(package, $$list("libdrm xcomposite xcursor xi xtst")) {`
`99`		`- !qtConfig(webengine-system-$$package) {`
`100`		`- skipBuild("A suitable version of $$package could not be found.")`
`101`		`- return(false)`
`102`		`- }`
`103`		`- }`
	`97`	`+ !qtConfig(webengine-embedded-build): qtConfig(xcb) : !qtConfig(webengine-ozone-x11) {`
	`98`	`+ skipBuild("Could not find all necessary libraries for qpa-xcb support")`
	`99`	`+ return(false)`
`104`	`100`	`}`
`105`	`101`	`}`
`106`	`102`	`}`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ host_build {`
`175`	`175`	`}`
`176`	`176`	`!packagesExist(libpci): gn_args += use_libpci=false`
`177`	`177`
`178`		`- qtConfig(webengine-system-x11): hasX11Dependencies() {`
	`178`	`+ qtConfig(webengine-ozone-x11) {`
`179`	`179`	`gn_args += ozone_platform_x11=true`
`180`	`180`	`packagesExist(xscrnsaver): gn_args += use_xscrnsaver=true`
`181`	`181`	`}`