Skip to content

Commit bc7ccb6

Browse files
Allan Sandfeld Jensenpatricia-gallardo
authored andcommitted
Fix leak in QQuickWebEngineViewPrivate::contextMenuRequested
Change-Id: Idb41daa68709c769330527a713689241ac073359 Reviewed-by: Kirill Burtsev <[email protected]>
1 parent b1296cd commit bc7ccb6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/webengine/api/qquickwebengineview.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,14 +235,14 @@ void QQuickWebEngineViewPrivate::contextMenuRequested(const WebEngineContextMenu
235235

236236
m_contextMenuData = data;
237237

238-
QQuickWebEngineContextMenuRequest *request = new QQuickWebEngineContextMenuRequest(data);
239238
QQmlEngine *engine = qmlEngine(q);
240239

241240
// TODO: this is a workaround for QTBUG-65044
242241
if (!engine)
243242
return;
244243

245244
// mark the object for gc by creating temporary jsvalue
245+
QQuickWebEngineContextMenuRequest *request = new QQuickWebEngineContextMenuRequest(data);
246246
engine->newQObject(request);
247247
Q_EMIT q->contextMenuRequested(request);
248248

0 commit comments

Comments
 (0)