Skip to content

Commit d391563

Browse files
author
Kirill Burtsev
committed
Fully setup replaced QMouseDblClickEvent with source and flags
Not fully preserving properties causes event to not be considered synthesized by system and be forwarded into chromium. Receiving one single press event and no release event confuses input event_handler and triggers infinite loop and renderer process crash for pages with multiple nested iframes. Fixes: QTBUG-62106 Change-Id: Iabb8bff78fc3475923b4aa3209b720453a5b6ce5 Reviewed-by: Alexandru Croitor <[email protected]>
1 parent 9bf361e commit d391563

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/webenginewidgets/render_widget_host_view_qt_delegate_widget.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ bool RenderWidgetHostViewQtDelegateWidget::event(QEvent *event)
471471
// where we can simply ignore the DblClick event.
472472
QMouseEvent *dblClick = static_cast<QMouseEvent *>(event);
473473
QMouseEvent press(QEvent::MouseButtonPress, dblClick->localPos(), dblClick->windowPos(), dblClick->screenPos(),
474-
dblClick->button(), dblClick->buttons(), dblClick->modifiers());
474+
dblClick->button(), dblClick->buttons(), dblClick->modifiers(), dblClick->source());
475475
press.setTimestamp(dblClick->timestamp());
476476
handled = m_client->forwardEvent(&press);
477477
} else

0 commit comments

Comments
 (0)