Skip to content

Commit d670f59

Browse files
author
Stephane Landelle
committed
Don't build request twice when using a proxy, close AsyncHttpClient#235
1 parent 3d79612 commit d670f59

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -937,9 +937,10 @@ private <T> ListenableFuture<T> doConnect(final Request request, final AsyncHand
937937

938938
boolean useSSl = isSecure(uri) && !useProxy;
939939
if (channel != null && channel.isOpen() && channel.isConnected()) {
940-
HttpRequest nettyRequest = buildRequest(config, request, uri, f != null && f.isConnectAllowed(), bufferedBytes, proxyServer);
940+
HttpRequest nettyRequest = null;
941941

942942
if (f == null) {
943+
nettyRequest = buildRequest(config, request, uri, false, bufferedBytes, proxyServer);
943944
f = newFuture(uri, request, asyncHandler, nettyRequest, config, this, proxyServer);
944945
} else {
945946
nettyRequest = buildRequest(config, request, uri, f.isConnectAllowed(), bufferedBytes, proxyServer);

0 commit comments

Comments
 (0)