Skip to content

Commit e1e2882

Browse files
committed
PR fixups
1 parent d02fe4a commit e1e2882

File tree

2 files changed

+3
-18
lines changed

2 files changed

+3
-18
lines changed

Jakefile.js

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,7 @@ task(TaskNames.lkg, [
161161
exec(`${host} ${Paths.scripts.produceLKG}`, () => {
162162
const sizeAfter = getDirSize(Paths.lkg);
163163
if (sizeAfter > (sizeBefore * 1.10)) {
164-
// throw new Error("The lib folder increased by 10% or more. This likely indicates a bug.");
165-
console.log("Seems too big");
164+
throw new Error("The lib folder increased by 10% or more. This likely indicates a bug.");
166165
}
167166

168167
complete();
@@ -362,20 +361,6 @@ file(Paths.servicesDefinitionFile, [TaskNames.coreBuild], function() {
362361
}
363362
}, { async: true });
364363

365-
/*
366-
file(Paths.tsserverLibraryDefinitionFile, [TaskNames.coreBuild, Paths.copyright, ...libraryTargets], function () {
367-
const content = fs.readFileSync(Paths.tsserverLibraryDefinitionFile, { encoding: 'utf-8' });
368-
const newContent =
369-
removeConstModifierFromEnumDeclarations(content) +
370-
`\nexport = ts` +
371-
`\nexport as namespace ts;`;
372-
373-
fs.writeFileSync(Paths.tsserverLibraryDefinitionFile, newContent, { encoding: 'utf-8' });
374-
});
375-
*/
376-
377-
378-
379364
function getLibraryTargets() {
380365
/** @type {{ libs: string[], paths?: Record<string, string>, sources?: Record<string, string[]> }} */
381366
const libraries = readJson("./src/lib/libs.json");
@@ -540,7 +525,6 @@ function cleanTestDirs() {
540525
}
541526

542527
jake.mkdirP(Paths.baselines.local);
543-
jake.mkdirP(Paths.baselines.localRwc);
544528
jake.mkdirP(Paths.baselines.localTest262);
545529
}
546530

@@ -627,6 +611,7 @@ function acceptBaseline(sourceFolder, targetFolder) {
627611
console.log('Accept baselines from ' + sourceFolder + ' to ' + targetFolder);
628612
var deleteEnding = '.delete';
629613

614+
jake.mkdirP(targetFolder);
630615
acceptBaselineFolder(sourceFolder, targetFolder);
631616

632617
function acceptBaselineFolder(sourceFolder, targetFolder) {

src/compiler/tsbuild.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ namespace ts {
11091109
return resolvedNames;
11101110
}
11111111

1112-
function buildAllProjects(): number {
1112+
function buildAllProjects(): ExitStatus {
11131113
const graph = getGlobalDependencyGraph();
11141114
if (graph === undefined) return ExitStatus.DiagnosticsPresent_OutputsSkipped;
11151115

0 commit comments

Comments
 (0)