Merge pull request microsoft#25809 from ajafff/verify-strict-options

correctly detect if strictNullChecks is enabled

Author: mhegazy

src/compiler/program.ts

@@ -2366,7 +2366,7 @@ namespace ts {
         }
 
         function verifyCompilerOptions() {
-            if (options.strictPropertyInitialization && !options.strictNullChecks) {
+            if (options.strictPropertyInitialization && !getStrictOptionValue(options, "strictNullChecks")) {
                 createDiagnosticForOptionName(Diagnostics.Option_0_cannot_be_specified_without_specifying_option_1, "strictPropertyInitialization", "strictNullChecks");
             }
 

tests/baselines/reference/optionsStrictPropertyInitializationStrict.js

@@ -0,0 +1,7 @@
+//// [optionsStrictPropertyInitializationStrict.ts]
+var x;
+
+
+//// [optionsStrictPropertyInitializationStrict.js]
+"use strict";
+var x;

tests/baselines/reference/optionsStrictPropertyInitializationStrict.symbols

@@ -0,0 +1,4 @@
+=== tests/cases/compiler/optionsStrictPropertyInitializationStrict.ts ===
+var x;
+>x : Symbol(x, Decl(optionsStrictPropertyInitializationStrict.ts, 0, 3))
+

tests/baselines/reference/optionsStrictPropertyInitializationStrict.types

@@ -0,0 +1,4 @@
+=== tests/cases/compiler/optionsStrictPropertyInitializationStrict.ts ===
+var x;
+>x : any
+

tests/cases/compiler/optionsStrictPropertyInitializationStrict.ts

@@ -0,0 +1,4 @@
+// @strict: true
+// @strictPropertyInitialization: true
+
+var x;